-
Notifications
You must be signed in to change notification settings - Fork 12k
Remove linefeed setting from editor config #2716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Would you be interested in making a PR to fix this? I'll review it. |
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 22, 2016
filipesilva
added a commit
that referenced
this issue
Oct 22, 2016
hollannikas
pushed a commit
to hollannikas/angular-cli
that referenced
this issue
Oct 23, 2016
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 23, 2016
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
OS: Windows 10
Versions:
angular-cli: 1.0.0-beta.15
node: 6.6.0
os: win32 x64
No failure, but the editor config"end_of_line = lf" is annoying for windows if the user has setup git with "core.autocrlf = true", which most people should have done by now. I don't see why the angular-cli project should take a position on this preference, or really any of them. Editorconfig is handy, but including a default one in any cli project can cause grief. I prefer checking out crlf on windows and my editors handle that fine. Having this in editorconfig would work if I set a local repository config for autocrlf=false or input, but then if I happen to use an editor that ignores the editorconfig I would end up committing crlf. It caused some confusion with another team member because every time he did a checkout his editor would tell him all the files he had open have changed.
The text was updated successfully, but these errors were encountered: