-
Notifications
You must be signed in to change notification settings - Fork 12k
[EsBuild] locale changed from "en" to "en-US" #26409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are you sure about this ? The default local id has been I've just checked on stackblitz, v15 already returned |
Hi @JeanMeche , well it returns "en" with our setup, using the old builder. We are specifying the locale values in the angular.json setup. I assume it should return the values in angular.json, where does it get " Switching between the two builder gives us 2 different values for LOCALE_ID injection value. Thank you for your quick reply. |
This looks similar to #26026 |
Hi @spock123, I am unable to replicate this discrepancies reported between the application and browser builder. Can you please provide a reproduction?
|
Hi @alan-agius4 I shall try to make a simple version, I'll have to simplify our application a lot but I'll give it a shot. |
A good way to make a minimal repro is to create a new app via |
I bet it works if I do that /s .. we shall see hehe |
Hi, just to clarify that this is not a unique case: we have the same problem as here and in #26026. The LOCALE_ID returns 'en-US' for each language. I have tried to reproduce the issue with a minimal project, but without success. (In the minimal project, everything works as it should). I will have another look in the coming days to see if I can reproduce it. |
Can you check if you replace |
Hi @alan-agius4, thanks for your work! I have replaced it, but the error persists. I have also tested the new build system ( |
@vorlif this issue is about the application builder, if you are experiment the problem with the webpack based builder. It’s different. |
@alan-agius4 Sorry, I should have written that in more detail. Here the builder and my the results when I open the created
It works correctly with the old build system (Webpack), but not with the new build systems. I think this is the same issue as described here. @spock123 Did you use the application builder ( So I think you have tested |
@vorlif thanks, now I don't feel so alone :) |
@spock123, even for you #26409 (comment) doesn't fix your issue? |
I haven't tested it yet, will try tonight :)
…On Fri, Nov 24, 2023 at 1:58 PM Alan Agius ***@***.***> wrote:
@spock123 <https://github.com/spock123>, even for you #26409 (comment)
<#26409 (comment)>
doesn't fix your issue?
—
Reply to this email directly, view it on GitHub
<#26409 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJVM5BIRANYTHRMWTNGSD3YGCKW5AVCNFSM6AAAAAA7Q5H26GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRVGY2DEMZTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Okay, I've found the problem for myself. My IDE has automatically added this import
Then I use in the code:
If I remove the import, the problem is solved. |
Hey!! that fixed it!!!! @alan-agius4 |
@vorlif how did you get angular.json configured with the application builder btw? I use @angular-devkit/build-angular:browser-esbuild, and if I replace that with @angular-devkit/build-angular:application, I get this syntax error for angular.json:
|
You have to replace |
@spock123, thanks for confirming that the proposed change fixes your issue. |
@alan-agius4 : Just to chime in here, your fix also fixed it for me. Thank you! Any idea when we will see that in production? |
My guess is within the next 2 days. Last release was about 8 days ago, so it's about this time a new bugfix release comes out. |
Release happen mostly on wednesday. Last week was a bit particular because of Thanksgiving 👌 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Which @angular/* package(s) are the source of the bug?
localize, Don't known / other
Is this a regression?
Yes
Description
Before upgrading our product to Angular 17, our default LOCALE_ID was "en"
After upgrading and switching to Application builder, the LOCALE_ID value is now set to "en-US"
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
Please provide the environment you discovered this bug in (run
ng version
)Anything else?
Angular.json:
The text was updated successfully, but these errors were encountered: