-
Notifications
You must be signed in to change notification settings - Fork 12k
esbuild doesn't watch for local library changes while running dev server (cli-cache-enabled=false,preserveSymlinks=true) #25753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
tested with angular v17.0.6 and #26585 (comment) problem is probably:
|
Hi @vfg12e9w, I am unable to replicate this, kindly provide a minimal reproduction. |
@3z6tfx6d, from the repro steps, it doesn’t look like your configuring the typescript path mappings are described in #26585 (comment) |
repeat the steps and you will see that it does not work regardless of whether you write the typescript path mappings (#26585 (comment)) or not I'm crazy, but I'm not that crazy therefore it is questionable whether #26585 is actually fixed or not, because the steps are more or less the same |
…ibrary from another workspace when `preserveSymlinks` is `true` Prior to this change, watching of an `npm link` of a library in another workspace when `preserveSymlinks` was set to `true` was not being picked up as `node_modules` files were always ignored. Closes angular#25753
…ibrary from another workspace when `preserveSymlinks` is `true` Prior to this change, watching of an `npm link` of a library in another workspace when `preserveSymlinks` was set to `true` was not being picked up as `node_modules` files were always ignored. Closes #25753
…ibrary from another workspace when `preserveSymlinks` is `true` Prior to this change, watching of an `npm link` of a library in another workspace when `preserveSymlinks` was set to `true` was not being picked up as `node_modules` files were always ignored. Closes #25753 (cherry picked from commit 2909daf)
I can confirm that in version 17.0.7 it works with cli-cache-enabled=false and preserveSymlinks=true |
I have the same problem in 17.0.9 regardless of cli cache or preserveSymlinks properties. That doesn't seems like everything is working fine:
|
Hi everyone, I to am seeing this issue after upgrading to Angular v17.1.0. My Local Setup: fwiw, I have spent the last 6 hours trying to find a solution to no avail. The problem: So it seems to be a webpack caching issue. Any help would be greatly appreciated, thank you. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Command
serve
Is this a regression?
The previous version in which this bug was not present was
No response
Description
see #25569
library changes are not reflected when using "cli-cache-enabled"=false and "preserveSymlinks"=true and esbuild
when using "@angular-devkit/build-angular:browser" instead of "@angular-devkit/build-angular:browser-esbuild" everything works fine
angular.json
when using "cli-cache-enabled"=true and remove "preserveSymlinks" from otions everything works fine
when using "cli-cache-enabled"=false and remove "preserveSymlinks" application won't start
when using "cli-cache-enabled"=true and "preserveSymlinks"=true changes are not detected
when using "cli-cache-enabled"=true and "preserveSymlinks"=false everything works fine
when using "cli-cache-enabled"=false and "preserveSymlinks"=true changes are not detected
when using "cli-cache-enabled"=false and "preserveSymlinks"=false application won't start
everything works fine = ts and html changes from library work, scss from library doesn't work
I expected to change "@angular-devkit/build-angular:browser" to "@angular-devkit/build-angular:browser-esbuild" and everything would work, but now I will end up in psychiatry because of esbuild
Minimal Reproduction
see #25569
Exception or Error
No response
Your Environment
Anything else relevant?
No response
The text was updated successfully, but these errors were encountered: