Skip to content

Emit external component styles sourcemap when optimization is enabled #24049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alan-agius4 opened this issue Oct 11, 2022 · 4 comments · Fixed by #26711
Closed

Emit external component styles sourcemap when optimization is enabled #24049

alan-agius4 opened this issue Oct 11, 2022 · 4 comments · Fixed by #26711
Labels
area: @angular-devkit/build-angular feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature Issue that requests a new feature

Comments

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Oct 11, 2022

Command

build

Description

Currently, when optimization is enabled, components sourcemaps are always disabled.

Describe the solution you'd like

This is a request to add support for CSS sourcemaps for components when optimization is enabled which can be done by instead of inline sourcemaps as base64 in the JS file we emit the sourcemap as an external file.

This does come with the drawback that a lot of .map files will be emitted. (1 per component stylesheet)

More context: #22834

@angular-robot
Copy link
Contributor

angular-robot bot commented Oct 11, 2022

This feature request is now candidate for our backlog! In the next phase, the community has 60 days to upvote. If the request receives more than 20 upvotes, we'll move it to our consideration list.

You can find more details about the feature request process in our documentation.

@angular-robot angular-robot bot added the feature: votes required Feature request which is currently still in the voting phase label Oct 11, 2022
@angular-robot
Copy link
Contributor

angular-robot bot commented Nov 19, 2022

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@angular-robot
Copy link
Contributor

angular-robot bot commented Dec 9, 2022

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

@angular-robot angular-robot bot added feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors and removed feature: votes required Feature request which is currently still in the voting phase labels Dec 9, 2022
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Dec 19, 2023
…ponent styles

This commits, changed the behaviour by emitting component sourcemaps in external files instead of inlining them.

Closes angular#24049 and closes angular#26676
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Dec 19, 2023
…ponent styles

This commits, changes the behaviour in the esbuild based builders by emitting component sourcemaps in external files instead of inlining them.

Closes angular#24049 and closes angular#26676
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Dec 19, 2023
…ponent styles

This commits, changes the behaviour in the esbuild based builders by emitting component sourcemaps in external files instead of inlining them.

Closes angular#24049 and closes angular#26676
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Dec 19, 2023
…ponent styles

This commits, changes the behaviour in the esbuild based builders by emitting component sourcemaps in external files instead of inlining them.

Closes angular#24049 and closes angular#26676
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Dec 20, 2023
…ponent styles

This commits, changes the behaviour in the esbuild based builders by emitting component sourcemaps in external files instead of inlining them.

Closes angular#24049 and closes angular#26676
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Dec 20, 2023
…ponent styles

This commits, changes the behaviour in the esbuild based builders by emitting component sourcemaps in external files instead of inlining them.

Closes angular#24049 and closes angular#26676
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Dec 20, 2023
…ponent styles

This commits, changes the behaviour in the esbuild based builders by emitting component sourcemaps in external files instead of inlining them.

Closes angular#24049 and closes angular#26676
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Dec 20, 2023
…ponent styles

This commits, changes the behaviour in the esbuild based builders by emitting component sourcemaps in external files instead of inlining them.

Closes angular#24049 and closes angular#26676
alan-agius4 added a commit that referenced this issue Dec 20, 2023
…ponent styles

This commits, changes the behaviour in the esbuild based builders by emitting component sourcemaps in external files instead of inlining them.

Closes #24049 and closes #26676
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular-devkit/build-angular feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature Issue that requests a new feature
Projects
None yet
1 participant