Skip to content

ng deploy should not recommend @azure/ng-deploy as an example #23255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 16 tasks
doggy8088 opened this issue May 31, 2022 · 3 comments · Fixed by #23305
Closed
1 of 16 tasks

ng deploy should not recommend @azure/ng-deploy as an example #23255

doggy8088 opened this issue May 31, 2022 · 3 comments · Fixed by #23305
Labels
area: @angular/cli area: docs Related to the documentation freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient
Milestone

Comments

@doggy8088
Copy link
Contributor

doggy8088 commented May 31, 2022

🐞 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • extract-i18n
  • run
  • config
  • help
  • version
  • doc
  • deploy

Is this a regression?

No

Description

The @azure/ng-deploy is outdated and only support Angular 9 at this moment. I think this one should be removed from the example to avoid confusion to newbies.

image

🔬 Minimal Reproduction

npx @angular/[email protected] new demo1 --routing --style=css
cd demo1
ng deploy
ng add @azure/ng-deploy

🔥 Exception or Error


Skipping installation: Package already installed
An unhandled exception occurred: NOT SUPPORTED: keyword "id", use "$id" for schema ID
See "C:\Users\wakau\AppData\Local\Temp\ng-obGdVe\angular-errors.log" for further details.

🌍 Your Environment


Angular CLI: 13.3.7
Node: 16.15.0
Package Manager: npm 8.5.5
OS: win32 x64

Angular: 13.3.10
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1303.7
@angular-devkit/build-angular   13.3.7
@angular-devkit/core            13.3.7
@angular-devkit/schematics      13.3.7
@angular/cli                    13.3.7
@schematics/angular             13.3.7
rxjs                            7.5.5
typescript                      4.6.4

Anything else relevant?

This issue is related to #22978 and microsoft/playwright#11258

@alan-agius4
Copy link
Collaborator

Checked with @mgechev and we should remove @azure/ng-deploy from the list until an update is released.

NB: This change also needs to be done in AIO https://github.com/angular/angular/blob/68a6a075f4aeab1788a1bba736bfcb428cfbbacb/aio/content/guide/deployment.md
FYI @manekinekko.

@alan-agius4 alan-agius4 added area: docs Related to the documentation area: @angular/cli labels May 31, 2022
@ngbot ngbot bot modified the milestone: Backlog May 31, 2022
@alan-agius4 alan-agius4 added severity2: inconvenient freq1: low Only reported by a handful of users who observe it rarely good first issue labels May 31, 2022
@manekinekko
Copy link
Contributor

Thank for the heads-up @alan-agius4 @mgechev. In all transparency, the core maintainer of that package has left our team. I am working with the rest of the team to plan a better maintenance strategy for this package. I am prioritizing this work for the next week and will keep you posted.

I apologize to everyone for the inconvenience, on behalf of the whole team.

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Jun 7, 2022
This builder is not compatible with newer versions of the Angular CLI.

See angular#23255 for more context

Closes angular#23255
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Jun 7, 2022
This builder is not compatible with newer versions of the Angular CLI.

See angular/angular-cli#23255 for more context
clydin pushed a commit that referenced this issue Jun 8, 2022
This builder is not compatible with newer versions of the Angular CLI.

See #23255 for more context

Closes #23255
clydin pushed a commit that referenced this issue Jun 8, 2022
This builder is not compatible with newer versions of the Angular CLI.

See #23255 for more context

Closes #23255

(cherry picked from commit 1323421)
alxhub pushed a commit to angular/angular that referenced this issue Jun 8, 2022
This builder is not compatible with newer versions of the Angular CLI.

See angular/angular-cli#23255 for more context

PR Close #46285
alxhub pushed a commit to angular/angular that referenced this issue Jun 8, 2022
This builder is not compatible with newer versions of the Angular CLI.

See angular/angular-cli#23255 for more context

PR Close #46285
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular/cli area: docs Related to the documentation freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants