Skip to content

Check for tailwind.config.cjs when detecting tailwind #23236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 15 tasks
L2jLiga opened this issue May 26, 2022 · 1 comment · Fixed by #23240
Closed
2 of 15 tasks

Check for tailwind.config.cjs when detecting tailwind #23236

L2jLiga opened this issue May 26, 2022 · 1 comment · Fixed by #23240
Labels
area: @angular-devkit/build-angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Milestone
Backlog

Comments

@L2jLiga
Copy link
Contributor

L2jLiga commented May 26, 2022

🚀 Feature request

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • extract-i18n
  • run
  • config
  • help
  • version
  • doc

Description

Tailwind uses require to load config and it breaks build when ""type": module" is set in package.json

Describe the solution you'd like

Tailwind itself looking for both tailwind.config.js and tailwind.config.cjs

Looking for tailwind config with both extensions (js, cjs) to determine whether project use it or not
@ngbot ngbot bot added this to the needsTriage milestone May 27, 2022
@alan-agius4 alan-agius4 added freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix and removed devkit/build-angular:browser labels May 27, 2022
@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 27, 2022
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue May 27, 2022
@alan-agius4
fix(@angular-devkit/build-angular): detect tailwind.config.cjs as v…
893095d 
…alid tailwinds configuration

`tailwind.config.cjs` is a valid tailwindcss configuration file as it's listed in https://github.com/tailwindlabs/tailwindcss/blob/8845d112fb62d79815b50b3bae80c317450b8b92/src/util/resolveConfigPath.js#L46-L52 as such we should also take this filename into consideration.

Closes angular#23236
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue May 27, 2022
@alan-agius4
fix(@angular-devkit/build-angular): detect tailwind.config.cjs as v…
5952fea 
…alid tailwinds configuration

`tailwind.config.cjs` is a valid tailwindcss configuration file as it's listed in https://github.com/tailwindlabs/tailwindcss/blob/8845d112fb62d79815b50b3bae80c317450b8b92/src/util/resolveConfigPath.js#L46-L52 as such we should also take this filename into consideration.

Closes angular#23236
@alan-agius4 alan-agius4 mentioned this issue May 27, 2022
Merged
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue May 27, 2022
@alan-agius4
fix(@angular-devkit/build-angular): detect tailwind.config.cjs as v…
ffb94ba 
…alid tailwinds configuration

`tailwind.config.cjs` is a valid tailwindcss configuration file as it's listed in https://github.com/tailwindlabs/tailwindcss/blob/8845d112fb62d79815b50b3bae80c317450b8b92/src/util/resolveConfigPath.js#L46-L52 as such we should also take this filename into consideration.

Closes angular#23236
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue May 27, 2022
@alan-agius4
fix(@angular-devkit/build-angular): detect tailwind.config.cjs as v…
05da2a2 
…alid tailwindcss configuration

`tailwind.config.cjs` is a valid tailwindcss configuration file as it's listed in https://github.com/tailwindlabs/tailwindcss/blob/8845d112fb62d79815b50b3bae80c317450b8b92/src/util/resolveConfigPath.js#L46-L52 as such we should also take this filename into consideration.

Closes angular#23236
clydin pushed a commit that referenced this issue May 27, 2022
@alan-agius4 @clydin
fix(@angular-devkit/build-angular): detect tailwind.config.cjs as v…
ee2e756 
…alid tailwindcss configuration

`tailwind.config.cjs` is a valid tailwindcss configuration file as it's listed in https://github.com/tailwindlabs/tailwindcss/blob/8845d112fb62d79815b50b3bae80c317450b8b92/src/util/resolveConfigPath.js#L46-L52 as such we should also take this filename into consideration.

Closes #23236
clydin pushed a commit that referenced this issue May 27, 2022
@alan-agius4 @clydin
fix(@angular-devkit/build-angular): detect tailwind.config.cjs as v…
48630cc 
…alid tailwindcss configuration

`tailwind.config.cjs` is a valid tailwindcss configuration file as it's listed in https://github.com/tailwindlabs/tailwindcss/blob/8845d112fb62d79815b50b3bae80c317450b8b92/src/util/resolveConfigPath.js#L46-L52 as such we should also take this filename into consideration.

Closes #23236

(cherry picked from commit ee2e756)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: @angular-devkit/build-angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
Milestone
Backlog
2 participants
@L2jLiga @alan-agius4