Skip to content

when using app-shell and i18n, the urls and hashTable in ngsw.json will generate the wrong path. #22389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 15 tasks
gzf6 opened this issue Dec 16, 2021 · 1 comment · Fixed by #23454
Closed
1 of 15 tasks
Assignees
Labels
2022Q3 Fixit Candidates for the Q3 2022 fix-it area: @angular-devkit/build-angular devkit/build-angular:app-shell freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Milestone

Comments

@gzf6
Copy link

gzf6 commented Dec 16, 2021

🐞 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • extract-i18n
  • run
  • config
  • help
  • version
  • doc

Is this a regression?

no

Description

when using i18n, the urls and hashTable in ngsw.json will generate the wrong path.

🔬 Minimal Reproduction

🔥 Exception or Error

now in ngsw.json, the urls example:
/favicon.ico
but the right path should be like:
/en-US/favicon.ico

🌍 Your Environment


Angular CLI: 13.1.2
Node: 16.13.0
Package Manager: npm 8.1.0
OS: win32 x64

Angular: 13.1.1
... animations, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic
... platform-server, router, service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1301.2
@angular-devkit/build-angular   13.1.2
@angular-devkit/core            13.1.2
@angular-devkit/schematics      13.1.2
@angular/cli                    13.1.2
@schematics/angular             13.1.2
rxjs                            7.4.0
typescript                      4.5.4

Anything else relevant?

@ngbot ngbot bot modified the milestone: needsTriage Dec 16, 2021
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Dec 16, 2021
@alan-agius4 alan-agius4 self-assigned this Jun 28, 2022
@alan-agius4 alan-agius4 added the 2022Q3 Fixit Candidates for the Q3 2022 fix-it label Jun 28, 2022
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Jun 28, 2022
…anifest when using i18n and app-shell

Previously, the base href was not set when using the app-shell builder and i18n.

Closes angular#22389
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Jun 28, 2022
…anifest when using i18n and app-shell

Previously, the base href was not set when using the app-shell builder and i18n.

Closes angular#22389
clydin pushed a commit that referenced this issue Jun 28, 2022
…anifest when using i18n and app-shell

Previously, the base href was not set when using the app-shell builder and i18n.

Closes #22389
clydin pushed a commit that referenced this issue Jun 28, 2022
…anifest when using i18n and app-shell

Previously, the base href was not set when using the app-shell builder and i18n.

Closes #22389

(cherry picked from commit 43f495d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2022Q3 Fixit Candidates for the Q3 2022 fix-it area: @angular-devkit/build-angular devkit/build-angular:app-shell freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
2 participants