Skip to content

Add the ability to skip dependencies with ng update #18813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 15 tasks
pavankjadda opened this issue Sep 17, 2020 · 4 comments · Fixed by #18888
Closed
1 of 15 tasks

Add the ability to skip dependencies with ng update #18813

pavankjadda opened this issue Sep 17, 2020 · 4 comments · Fixed by #18888
Assignees
Milestone

Comments

@pavankjadda
Copy link

🚀 Feature request

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Description

At present when I do ng update --all, the command fails when it finds incompatible dependencies(Attached image). I force update all dependencies and revert back incompatible dependencies through a shell script

Screen Shot 2020-09-17 at 4 46 35 PM

Describe the solution you'd like

Provide the ability to skip dependencies through flag like below

ng update --all --skip "zone.js"

Describe alternatives you've considered

I have a script that force updates the all dependencies and reverts incompatible dependencies

### Update all dependencies
ng update --all --force

### Install compatible zone.js version
npm i [email protected] --save

@alan-agius4 alan-agius4 added area: build & ci Related the build and CI infrastructure of the project area: @schematics/angular ng update DX labels Sep 17, 2020
@ngbot ngbot bot modified the milestone: needsTriage Sep 17, 2020
@alan-agius4 alan-agius4 added comp: schematics/update needs: discussion On the agenda for team meeting to determine next steps and removed area: build & ci Related the build and CI infrastructure of the project area: @schematics/angular labels Sep 17, 2020
@alan-agius4
Copy link
Collaborator

Also related to #15296

@alan-agius4 alan-agius4 self-assigned this Sep 25, 2020
@alan-agius4 alan-agius4 removed the needs: discussion On the agenda for team meeting to determine next steps label Sep 25, 2020
alan-agius4 added a commit that referenced this issue Sep 29, 2020
'--all' functionality has been removed from `ng update` as updating multiple packages at once is not recommended. To update the depencencies in your workspace 'package.json' use the update command of your package manager.

Closes #15278
Closes #13095
Closes #12261
Closes #12243
Closes #18813
@pavankjadda
Copy link
Author

@alan-agius4 Does this mean we have to use npm update command from now on? When will this change be pushed to CLI npm package?

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Sep 29, 2020

@pavankjadda, yes. For packages which do not explicitly support ng update. You should update packages which support ng update prior to running the package manager update command.

This will be available in v11.0.0-next.4.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants