Skip to content

Lint Issue: Angular CLI generate app-routing.module.ts with consecutive blank lines #18220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 15 tasks
kumaran-is opened this issue Jul 10, 2020 · 2 comments · Fixed by #18226
Closed
1 of 15 tasks

Comments

@kumaran-is
Copy link

kumaran-is commented Jul 10, 2020

🐞 Bug report

Command (mark with an x)

app-routing.module.ts generated by Angular-cli v9 has consecutive blank lines( line 3 & 4 in below screenshot) , causing lint issue. This was not happening in Angular-cli v8.

Screen Shot 2020-07-10 at 3 50 59 PM

with tslint.json configuration,

"rules": {
"no-consecutive-blank-lines":true
}

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Is this a regression?

This was not happening in Angular-cli v8.

Description

As mentioned above.

🔬 Minimal Reproduction

  • Install angular cli 9.1 npm install -g @angular/cli@9
  • Create a new project ng new my-app with route
  • Update your tslint.json configuration with below rule

"rules": {
"no-consecutive-blank-lines": true
}

  • Run. ng lint

  • Lint fails with below error

/Users/work/Angular9/my-app/src/app/app-routing.module.ts:4:1
ERROR: 4:1 no-consecutive-blank-lines Consecutive blank lines are forbidden

Lint errors found in the listed files.
npm ERR! code ELIFECYCLE
npm ERR! errno 1

🌍 Your Environment

Angular CLI: 9.1.11
Node: 12.13.0
OS: darwin x64

Angular:
...
Ivy Workspace:

Package Version

@angular-devkit/architect 0.901.11
@angular-devkit/core 9.1.11
@angular-devkit/schematics 9.1.11
@schematics/angular 9.1.11
@schematics/update 0.901.11
rxjs 6.5.4

@ngbot ngbot bot modified the milestone: needsTriage Jul 11, 2020
@alan-agius4 alan-agius4 added the freq1: low Only reported by a handful of users who observe it rarely label Jul 11, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jul 11, 2020
@sacgrover
Copy link
Contributor

Please assign to me

sacgrover added a commit to sacgrover/angular-cli that referenced this issue Jul 11, 2020
sacgrover added a commit to sacgrover/angular-cli that referenced this issue Jul 11, 2020
sacgrover added a commit to sacgrover/angular-cli that referenced this issue Jul 11, 2020
sacgrover added a commit to sacgrover/angular-cli that referenced this issue Jul 13, 2020
sacgrover added a commit to sacgrover/angular-cli that referenced this issue Jul 14, 2020
clydin pushed a commit that referenced this issue Jul 15, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants