Skip to content

karma-coverage-istanbul-reporter author requires payment for support and issue reporting #17757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
muuvmuuv opened this issue May 19, 2020 · 6 comments · Fixed by #17901
Closed
1 task done

Comments

@muuvmuuv
Copy link

muuvmuuv commented May 19, 2020

🐞 Bug report

Command (mark with an x)

  • new

Is this a regression?

I don't know but I think it must have worked.

Description

I have installed a starter through ng new leaved everything the default and tried to create a coverage report by enabling karma-coverage-istanbul-reporter with reporters: ['progress', 'coverage-istanbul', 'kjhtml'],. This is how the author describes the installation on his repo. Sadly this does not work and just prints

Statements   : Unknown% ( 0/0 )
Branches     : Unknown% ( 0/0 )
Functions    : Unknown% ( 0/0 )
Lines        : Unknown% ( 0/0 )

I tried to fill an issue but this author REALLY WANTS $100/month for that!!! This is in acceptable for an OSS project despite the fact that it is coupled to Angular. This makes me angry because new developer will see this and will get a wrong definition of what OSS is and maybe follow this behaviour. Sure, include a sponsor button and say that you don't want to work on it without receiving a SMALL amount of money but then add a "help wanted" badge and ask for help or use issuehunt. I would love to help to solve this issue but nope, my issue gets closed and locked (like many others).

I suggest removing that reporter from the starter and let the author know that this isn't a behaviour Angular supports.

🔬 Minimal Reproduction

Fresh starter with coverage enabled.

🔥 Exception or Error


Statements   : Unknown% ( 0/0 )
Branches     : Unknown% ( 0/0 )
Functions    : Unknown% ( 0/0 )
Lines        : Unknown% ( 0/0 )

🌍 Your Environment


Angular CLI: 9.1.6
Node: 12.16.1
OS: darwin x64

Angular: 9.1.7
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.901.6
@angular-devkit/build-angular     0.901.6
@angular-devkit/build-optimizer   0.901.6
@angular-devkit/build-webpack     0.901.6
@angular-devkit/core              9.1.6
@angular-devkit/schematics        9.1.6
@angular/cli                      9.1.6
@ngtools/webpack                  9.1.6
@schematics/angular               9.1.6
@schematics/update                0.901.6
rxjs                              6.5.5
typescript                        3.8.3
webpack                           4.42.0

Anything else relevant?

I don't know which coverage reporter I should use now...

@muuvmuuv
Copy link
Author

I forgot to use --code-coverage but anyway this doesn't change the way he forces users to pay for support. I cannot add this solution with --code-coverage now for other users because it is locked. Same question got asked on SO. And yes I should have searched the NG docs before ^^ sorry for that.

@ngbot ngbot bot added this to the needsTriage milestone May 19, 2020
@alan-agius4 alan-agius4 added hotlist: devRel needs: discussion On the agenda for team meeting to determine next steps labels May 19, 2020
@Splaktar Splaktar changed the title karma-coverage-istanbul-reporter does not work and author requires payment for support and issue reporting karma-coverage-istanbul-reporter author requires payment for support and issue reporting May 28, 2020
@Splaktar
Copy link
Contributor

Updated the title to reflect the fact that the plugin is actually working if used as documented.

@mgechev mgechev removed hotlist: devRel needs: discussion On the agenda for team meeting to determine next steps labels Jun 5, 2020
@SchnWalter
Copy link
Contributor

FYI: There's a draft MR for switching to karma-coverage: #17901

@MuthuD
Copy link

MuthuD commented Jun 15, 2020

I'm also facing this Unknown% issue when upgraded from Angular 6 to 9.
And I'm using --code-coverage, still not getting any coverage output.
Can someone guide me on this?

Are we going to change karma-coverage-Istanbul-reporter to karma-coverage?

@mattlewis92
Copy link
Contributor

Hey there, I just spotted this issue while looking for something else and thought I should offer an explanation. I've been writing and maintaining open source in my free time for the last 5 years and never earned a penny from it until earlier this year, it's extremely exhausting working on something in your spare time for free, especially when you know that the majority of your users are using it for profit. Charging for support on some of my repos was an experiment to see if I could make maintenance less of a burden, but I can now see that it wasn't a good idea, and I've taken it off in response to this issue as I think it causes more harm than good. I've got some better ideas around open source monetisation that are a bit less abrasive and work better to satisfy the needs of the community. Thanks for raising this issue and I really do appreciate the feedback ✌️

alan-agius4 pushed a commit to kyliau/angular-cli that referenced this issue Sep 6, 2020
This commit switches coverage tooling from karma-coverage-istanbul-reporter
to karma-coverage since it's better supported.

Closes angular#17757
alan-agius4 pushed a commit that referenced this issue Sep 6, 2020
This commit switches coverage tooling from karma-coverage-istanbul-reporter
to karma-coverage since it's better supported.

Closes #17757
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants