Add migration to change ts module to esnext

[alan-agius4]

🐞 Bug report

Command (mark with an x)

• new
• build
• serve
• test
• e2e
• generate
• add
• update
• lint
• xi18n
• run
• config
• help
• version
• doc

Description

In version 9 we are running the lazy-loading syntax migration to change the string based lazy-loading with import().

We however don't have a migration to ensure that that in the workspace tsconfig the module is set to esnext and this will failures at build time.

🔥 Exception or Error

ERROR in app/routing.module.ts:7:38 - error TS1323: Dynamic import is only supported when '--module' flag is 'commonjs' or 'esNext'.

7   {path: 'grid', loadChildren: () => import('./grid/grid.module').then(m => m.DocsGridModule)},
                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
app/routing.module.ts:8:38 - error TS1323: Dynamic import is only supported when '--module' flag is 'commonjs' or 'esNext'.

8   {path: 'docs', loadChildren: () => import('./layout/layout.module').then(m => m.DocsLayoutModule)},
                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
app/routing.module.ts:9:44 - error TS1323: Dynamic import is only supported when '--module' flag is 'commonjs' or 'esNext'.

9   {path: 'responsive', loadChildren: () => import('./responsive/responsive.module').then(m => m.DocsResponsiveModule)},
                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
app/routing.module.ts:10:40 - error TS1323: Dynamic import is only supported when '--module' flag is 'commonjs' or 'esNext'.

10   {path: 'issues', loadChildren: () => import('./github-issues/github-issues.module').then(m => m.DocsGithubIssuesModule)},
                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
app/routing.module.ts:13:25 - error TS1323: Dynamic import is only supported when '--module' flag is 'commonjs' or 'esNext'.

13     loadChildren: () => import('./stack-overflow/stack-overflow.module').then(m => m.DocsStackOverflowModule)

[filipesilva]

We did those things in the migration to 8 I believe:

angular-cli/packages/schematics/angular/migrations/update-8/differential-loading.ts

Lines 154 to 158 in 7d1247b

	} else if (scriptModule.value !== 'esnext') {
	const { start, end } = scriptModule;
	recorder.remove(start.offset, end.offset - start.offset);
	recorder.insertLeft(start.offset, '"esnext"');
	}

angular-cli/packages/schematics/angular/migrations/update-8/update-lazy-module-paths.ts

Line 55 in 7d1247b

const fix = `() => import('${path}').then(m => m.${moduleName})`;

[alan-agius4]

Yeah, but in v9 we are re-trigger the update-lazy-module-paths.ts since string based lazy loading doesn't work with Ivy. However, we are not re-trigger the Dl migration.

I have a PR, to address this; #16097

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}