update: missing space in version and command output

[Splaktar]

🐞 Bug report

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [x] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

Unknown

Description

Note that 9.0.0-next.8ng and 9.0.0-next.9ng are single strings without a space.

    We analyzed your package.json, there are some packages to update:
    
      Name                               Version                  Command to update
     --------------------------------------------------------------------------------
      @angular/cdk                       8.1.4 -> 9.0.0-next.0    ng update @angular/cdk --next
      @angular/cli                       9.0.0-next.3 -> 9.0.0-next.8ng update @angular/cli --next
      @angular/core                      9.0.0-next.5 -> 9.0.0-next.9ng update @angular/core --next
      @angular/material                  8.1.4 -> 9.0.0-next.0    ng update @angular/material --next

🔬 Minimal Reproduction

1. Create a project with @angular/[email protected]
2. Run ng update --next

🔥 Exception or Error

N/A

🌍 Your Environment

Angular CLI: 9.0.0-next.3
Node: 10.16.3
OS: darwin x64
Angular: 9.0.0-next.5
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
... service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.0-next.3
@angular-devkit/build-angular     0.900.0-next.3
@angular-devkit/build-optimizer   0.900.0-next.3
@angular-devkit/build-webpack     0.900.0-next.3
@angular-devkit/core              9.0.0-next.3
@angular-devkit/schematics        9.0.0-next.3
@angular/cdk                      8.1.4
@angular/cli                      9.0.0-next.3
@angular/fire                     5.2.1
@angular/language-service         8.2.5
@angular/material                 8.1.4
@angular/pwa                      0.900.0-next.3
@ngtools/webpack                  9.0.0-next.3
@schematics/angular               9.0.0-next.3
@schematics/update                0.900.0-next.3
rxjs                              6.5.3
typescript                        3.5.3
webpack                           4.39.3

Anything else relevant?
OS: macOS Mojave
PM: npm

[Splaktar]

The code in question appears to be here:

angular-cli/packages/schematics/update/update/index.ts

Lines 487 to 492 in ace02f6

	let command = `ng update ${name}`;
	if (tag == 'next') {
	command += ' --next';
	}
	return [name, `${info.installed.version} -> ${version}`, command];

I'm not sure if something as simple as this would fix it?

return [name, `${info.installed.version} -> ${version} `, command];

It looks like there are no tests for _usageMessage().

[Splaktar]

I tried to write a test, but it doesn't appear that runSchematicAsync() gives any access to the command's output. It only gives you the modified file tree, which isn't useful in this case.

[Splaktar]

OK, adding that space does help and gives

  Name                                                      Version                  Command to update
 -------------------------------------------------------------------------------------------------------
  @angular/cli                                              9.0.0-next.5 -> 9.0.0-next.8 ng update @angular/cli --next

And it still looks fine with non-next versions

  Name                                                      Version                  Command to update
 -------------------------------------------------------------------------------------------------------
  @angular/cli                                              8.0.0 -> 8.3.8           ng update @angular/cli

[Splaktar]

Opened PR #15786 to fix this.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}