Cannot read property 'ngMetadataName' of undefined with @angular-devkit/build-angular 0.800.4 #14888

vthinkxie · 2019-06-25T08:55:41Z

🐞 Bug report

Command (mark with an `x`)

- [ ] new
- [ ] build
- [ ] serve
- [x] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

Yes, the previous version in which this bug was not present was:
@angular-devkit/build-angular 0.800.3

Description

we met an error when update our lib ng-zorro-antd to the latest angular version.

All our ci goes wrong today, and found @Angular-devkit update to 0.800.4, and everthing is ok after locking it to 0.800.3

TypeError: Cannot read property 'ngMetadataName' of undefined

🔬 Minimal Reproduction

a success CI 19 hours ago(before 0.800.4 released): https://travis-ci.org/NG-ZORRO/ng-zorro-antd/jobs/549747080
a failed CI 5 hours ago(after 0.800.4 released): https://travis-ci.org/NG-ZORRO/ng-zorro-antd/jobs/550062443 (no code change between these two CI)
a sucess CI after seting @angular-devkit/build-angular to 0.800.3 https://travis-ci.org/NG-ZORRO/ng-zorro-antd/jobs/550171528

🔥 Exception or Error


TypeError: Cannot read property 'ngMetadataName' of undefined
	    at injectArgs (http://localhost:9876/_karma_webpack_/webpack:/node_modules/@angular/core/fesm5/core.js:573:1)
	    at http://localhost:9876/_karma_webpack_/webpack:/node_modules/@angular/core/fesm5/core.js:1091:72
	    at _callFactory (http://localhost:9876/_karma_webpack_/webpack:/node_modules/@angular/core/fesm5/core.js:18522:1)
	    at _createProviderInstance (http://localhost:9876/_karma_webpack_/webpack:/node_modules/@angular/core/fesm5/core.js:18480:1)
	    at resolveNgModuleDep (http://localhost:9876/_karma_webpack_/webpack:/node_modules/@angular/core/fesm5/core.js:18455:1)
	    at NgModuleRef_.push.../node_modules/@angular/core/fesm5/core.js.NgModuleRef_.get (http://localhost:9876/_karma_webpack_/webpack:/node_modules/@angular/core/fesm5/core.js:19149:1)
	    at resolveDep (http://localhost:9876/_karma_webpack_/webpack:/node_modules/@angular/core/fesm5/core.js:19520:1)
	    at createClass (http://localhost:9876/_karma_webpack_/webpack:/node_modules/@angular/core/fesm5/core.js:19400:1)
	    at createDirectiveInstance (http://localhost:9876/_karma_webpack_/webpack:/node_modules/@angular/core/fesm5/core.js:19271:1)
	    at createViewNodes (http://localhost:9876/_karma_webpack_/webpack:/node_modules/@angular/core/fesm5/core.js:27489:1)

The text was updated successfully, but these errors were encountered:

bjornharvold · 2019-06-25T09:06:42Z

I was just about to create the same ticket. I can confirm that our application was working with Angular CLI 8.0.3 and failed to load the SPA when upgrading to 8.0.4, as described above. We reverted to 8.0.3 and it works again.

alan-agius4 · 2019-06-25T10:12:35Z

From @cexbrayat

The failing tests are using services registered with providedIn: root and not declared in configureTestingModule. If I declare them explicitely in the providers of the testing module, the tests are green again

vahidvdn · 2019-06-25T11:49:23Z

I have the same issue after upgrading to Angular 8. Any idea?

hegenj · 2019-06-25T15:03:35Z

For me 2 things have worked:

using aot option to build and serve as well
downgrading the cli to 8.0.3

....

nicolae-olariu · 2019-06-25T15:53:05Z

@hegenj Thanks for your feedback. Downgrading cli to 8.0.3 also worked for us.

vahidvdn · 2019-06-25T17:28:21Z

This happens to me in the routes that I injected a service that injects the following:

@Inject(PLATFORM_ID) private platformId

The error occurred after updating to Angular 8. About workaround, I downgraded to 8.0.3 but still the same error. My package.json now :

"@angular-devkit/build-angular": "~0.800.3",
"@angular/cli": "~8.0.3",

It works fine with ng serve --aot

hegenj · 2019-06-25T20:58:24Z

I've downgraded the angular stuffs as well. If is still not working, let me know, and I'll send you my settings from package.json tomorrow morning. Nicolae Olariu <[email protected]> ezt írta (időpont: 2019. jún. 25., Ke 17:54):

…

@hegenj <https://github.com/hegenj> Thanks for your feedback. How did you manage to downgrade to 8.0.3? I've tried any possible npm command but I'm still stuck with 8.0.4 no matter what I do (even if I explicitly install 8.0.3 with npm install -g @***@***.***)... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14888?email_source=notifications&email_token=AMOKTWGLFAH5QUCWMLIM6B3P4I5R5A5CNFSM4H3F7QV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYQWZPQ#issuecomment-505507006>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMOKTWGTV4HHAW2QQ6CVXSLP4I5R5ANCNFSM4H3F7QVQ> .

vahidvdn · 2019-06-26T05:11:00Z

@hegenj No, downgrading didn't work for me. Just serving as --aot worked.

nicolae-olariu · 2019-06-26T06:16:42Z

@hegenj Downgrading cli to 8.0.3 fixed our issue. Thanks a lot!

hegenj · 2019-06-26T08:17:08Z

@vadim-shb
Have you downgraded the angular libraries as well. It seems that these are the latest ones were this error is not coming up: (Don't forget the exact versions in package.json !!! I see in your config the ~ sign!!!)
"dependencies": {
"@angular/animations": "8.0.2",
"@angular/common": "8.0.2",
"@angular/compiler": "8.0.2",
"@angular/core": "8.0.2",
"@angular/forms": "8.0.2",
"@angular/platform-browser": "8.0.2",
"@angular/platform-browser-dynamic": "8.0.2",
......
"devDependencies": {
"@angular-devkit/build-angular": "0.800.3",
"@angular-devkit/build-ng-packagr": "0.800.3",
"@angular/cli": "8.0.3",
"@angular/compiler-cli": "8.0.1",
"@angular/language-service": "8.0.1",

vahidvdn · 2019-06-26T08:51:03Z

@hegenj Thank you, now it works fine.

alan-agius4 · 2019-06-26T10:10:28Z

This might have been solved with #14891, can someone please try the nightly builds https://github.com/angular/angular-devkit-build-angular-builds and let us know?

Otherwise, it would be great if someone could create a minimal reproduction. Thanks.

vthinkxie · 2019-06-26T10:14:36Z

Hi @alan-agius4
thanks a lot!
I just run a CI to test it, it should have results in about 20mins
NG-ZORRO/ng-zorro-antd#3655

vthinkxie · 2019-06-26T10:28:04Z

@alan-agius4 the tests are still wrong after change dependency to nightly build
https://travis-ci.org/NG-ZORRO/ng-zorro-antd/jobs/550729866

anisabboud · 2019-06-26T10:50:42Z

After upgrading @angular-devkit/build-angular from 0.800.3 to 0.800.4, I got compile errors as well:

ERROR in ./src/app/forms/abc-form/abc-form.component.ts 352:16-24
"export 'ABC' was not found in 'app/models'

Reverting back to 0.800.3 resolves the errors (with @angular/cli version 8.0.3/8.0.4).

alan-agius4 · 2019-06-26T10:54:01Z

Thanks @vthinkxie for checking.

vthinkxie · 2019-06-26T11:03:25Z

After upgrading @angular-devkit/build-angular from 0.800.3 to 0.800.4, I got compile errors as well:
ERROR in ./src/app/forms/abc-form/abc-form.component.ts 352:16-24
"export 'ABC' was not found in 'app/models'
Reverting back to 0.800.3 resolves the errors (with @angular/cli version 8.0.3/8.0.4).

this error was fixed by the nightly build after checking, but the test error still there

vahidvdn · 2019-06-26T12:04:25Z

@alan-agius4

it would be great if someone could create a minimal reproduction

Did you check my comment?

taivu · 2019-06-26T13:51:07Z

for me to work i had to ng serve --aot with the following:

"@angular-devkit/build-angular": "~0.800.3",
"@angular/cli": "~8.0.3",

wangtao · 2019-06-27T12:29:21Z

same issue here +1

I have 2 projects created by cli 8.0.4

but only one works

another one only works with --aot

both of them work with cli 8.0.0

JhonArlex · 2019-06-27T18:54:05Z

i have the same problem. i migrate from angular 7 to 8.

tan9 · 2019-06-28T03:03:11Z

0.800.6 suffer from the same issue.

alfaproject · 2019-06-28T05:33:46Z

I've just upgraded to 8.0.6 (from 8.0.3 because I also got hit by the other 8.0.4 issue: #14891) and now I'm getting this issue instead: https://puu.sh/DLODB/932e7842ee.png

Serving with --aot is a workaround because it works fine, but I guess this is still a regression.

This project has about 50 apps/libs under an nx umbrella.

qortex · 2019-06-28T07:14:05Z

Same as @alfaproject
I get this error in the console when going to the website hosted with ng serve (with latest 0.800.6).
But using ng serve --aot works as a workaround.

tscislo · 2019-06-28T07:35:58Z

I can confirm that it works for me with
"@angular-devkit/build-angular": "^0.800.6",
"@angular-devkit/build-ng-packagr": "^0.800.6",
"@angular/cli": "^8.0.6",

keserwan · 2019-06-28T11:07:35Z

With these packages
"@angular-devkit/build-angular": "^0.800.6",
"@angular-devkit/build-ng-packagr": "^0.800.6",
"@angular/cli": "^8.0.6",

It works ONLY with ng serve --aot

matheo · 2019-06-28T19:04:55Z

Using 8.0.6 and dev-kit ~0.800.6 throws two errors while serving without aot, smells like a Circular Dependency problem:

Uncaught TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Object'
    |     property 'element' -> object with constructor 'Object'
    |     property 'publicProviders' -> object with constructor 'Object'
    |     property 'DefaultLayoutDirective_267' -> object with constructor 'Object'
    --- property 'parent' closes the circle

HarelM · 2019-06-29T19:49:02Z

I'm getting a different error Cannot read property 'default' of undefined after migrating from 8.0.4 to 8.0.6 when using ng build --watch, project can be found here: https://github.com/IsraelHikingMap/Site

In the recent versions of the CLI we introduced a ctor downleveler tranformer for VE JIT builds based on the one found in tsickle, to fix the TDZ issue of `forwardRef`. However this caused a regression as the injector is not handling that a position `paramType` can be undefined. Which is bubbled down to https://github.com/angular/angular/blob/c6b29f4c6d23b1510db3434cb030203d5bdea119/packages/core/src/di/injector_compatibility.ts#L162 and will crash https://github.com/angular/angular/blob/c6b29f4c6d23b1510db3434cb030203d5bdea119/packages/core/src/di/injector_compatibility.ts#L174-L186 Fixes angular/angular-cli#14888 PR Close #31333

SchneiterT · 2019-07-22T13:04:35Z

After updating from 8.0.2, I'm getting an odd Circular dependency warning from Service -> Class -> Service, where Class is not an Injectable. I posted the issue here

At the same time i have the runtime error:
TypeError: annotationCls is not a constructor when running without --aot

Might be connected to this.

angular-automatic-lock-bot · 2019-09-09T18:41:35Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

cipchk mentioned this issue Jun 25, 2019

export 'ITokenService' was not found in '@delon/auth' ng-alain/ng-alain#1183

Closed

alan-agius4 added area: @ngtools/webpack severity5: regression labels Jun 25, 2019

ngbot bot modified the milestone: needsTriage Jun 25, 2019

alan-agius4 added freq3: high type: bug/fix labels Jun 25, 2019

ngbot bot modified the milestones: needsTriage, Backlog Jun 25, 2019

alan-agius4 pinned this issue Jun 25, 2019

filipesilva modified the milestones: Backlog, 8.0.x Jun 25, 2019

alan-agius4 mentioned this issue Jun 26, 2019

TypeError : meta is undefined, @angular-devkit/build-angular: 0.800.3 => 0.800.4 #14910

Closed

cpboyd mentioned this issue Jun 26, 2019

export MatProgressSpinnerDefaultOptions not found angular/angular#31257

Closed

cipchk mentioned this issue Jun 27, 2019

Uncaught Error: Can't resolve all parameters for DelonModule: (?). ng-alain/ng-alain#1188

Closed

alfaproject mentioned this issue Jun 28, 2019

Error when using exported interface #14876

Closed

geraldpereira mentioned this issue Jun 28, 2019

Update to Angular 8 OctoPerf/kraken#24

Closed

alan-agius4 mentioned this issue Jun 28, 2019

fix(core): handle undefined meta in injectArgs angular/angular#31333

Closed

14 tasks

cyrilletuzi mentioned this issue Jun 28, 2019

chore(deps): update angularcli monorepo cyrilletuzi/angular-async-local-storage#130

Merged

1 task

alxhub closed this as completed in angular/angular@f83dfd6 Jul 1, 2019

flavens mentioned this issue Jul 3, 2019

chore: Upgrade to Angular 8 dasch-swiss/knora-ui#262

Merged

steve-todorov added a commit to LeifBrooks/strongbox-web-ui that referenced this issue Jul 9, 2019

Issue-1143: Upgrading Angular dependencies (angular/angular-cli#14888)

505586e

iget-master mentioned this issue Jul 10, 2019

CHANGELOG.md shouldn't include pre-release changes? angular/angular#31491

Closed

alan-agius4 unpinned this issue Jul 21, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot read property 'ngMetadataName' of undefined with @angular-devkit/build-angular 0.800.4 #14888

Cannot read property 'ngMetadataName' of undefined with @angular-devkit/build-angular 0.800.4 #14888

vthinkxie commented Jun 25, 2019 •

edited

Loading

bjornharvold commented Jun 25, 2019

alan-agius4 commented Jun 25, 2019

vahidvdn commented Jun 25, 2019

hegenj commented Jun 25, 2019 •

edited

Loading

nicolae-olariu commented Jun 25, 2019 •

edited

Loading

vahidvdn commented Jun 25, 2019 •

edited

Loading

hegenj commented Jun 25, 2019 via email

vahidvdn commented Jun 26, 2019

nicolae-olariu commented Jun 26, 2019

hegenj commented Jun 26, 2019 •

edited

Loading

vahidvdn commented Jun 26, 2019

alan-agius4 commented Jun 26, 2019

vthinkxie commented Jun 26, 2019

vthinkxie commented Jun 26, 2019

anisabboud commented Jun 26, 2019

alan-agius4 commented Jun 26, 2019

vthinkxie commented Jun 26, 2019

vahidvdn commented Jun 26, 2019

taivu commented Jun 26, 2019

wangtao commented Jun 27, 2019 •

edited

Loading

JhonArlex commented Jun 27, 2019 •

edited

Loading

tan9 commented Jun 28, 2019

alfaproject commented Jun 28, 2019

qortex commented Jun 28, 2019 •

edited

Loading

tscislo commented Jun 28, 2019

keserwan commented Jun 28, 2019

matheo commented Jun 28, 2019

HarelM commented Jun 29, 2019

SchneiterT commented Jul 22, 2019

angular-automatic-lock-bot bot commented Sep 9, 2019

Cannot read property 'ngMetadataName' of undefined with @angular-devkit/build-angular 0.800.4 #14888

Cannot read property 'ngMetadataName' of undefined with @angular-devkit/build-angular 0.800.4 #14888

Comments

vthinkxie commented Jun 25, 2019 • edited Loading

🐞 Bug report

Command (mark with an x)

Is this a regression?

Description

🔬 Minimal Reproduction

🔥 Exception or Error

bjornharvold commented Jun 25, 2019

alan-agius4 commented Jun 25, 2019

vahidvdn commented Jun 25, 2019

hegenj commented Jun 25, 2019 • edited Loading

nicolae-olariu commented Jun 25, 2019 • edited Loading

vahidvdn commented Jun 25, 2019 • edited Loading

hegenj commented Jun 25, 2019 via email

vahidvdn commented Jun 26, 2019

nicolae-olariu commented Jun 26, 2019

hegenj commented Jun 26, 2019 • edited Loading

vahidvdn commented Jun 26, 2019

alan-agius4 commented Jun 26, 2019

vthinkxie commented Jun 26, 2019

vthinkxie commented Jun 26, 2019

anisabboud commented Jun 26, 2019

alan-agius4 commented Jun 26, 2019

vthinkxie commented Jun 26, 2019

vahidvdn commented Jun 26, 2019

taivu commented Jun 26, 2019

wangtao commented Jun 27, 2019 • edited Loading

JhonArlex commented Jun 27, 2019 • edited Loading

tan9 commented Jun 28, 2019

alfaproject commented Jun 28, 2019

qortex commented Jun 28, 2019 • edited Loading

tscislo commented Jun 28, 2019

keserwan commented Jun 28, 2019

matheo commented Jun 28, 2019

HarelM commented Jun 29, 2019

SchneiterT commented Jul 22, 2019

angular-automatic-lock-bot bot commented Sep 9, 2019

vthinkxie commented Jun 25, 2019 •

edited

Loading

Command (mark with an `x`)

hegenj commented Jun 25, 2019 •

edited

Loading

nicolae-olariu commented Jun 25, 2019 •

edited

Loading

vahidvdn commented Jun 25, 2019 •

edited

Loading

hegenj commented Jun 26, 2019 •

edited

Loading

wangtao commented Jun 27, 2019 •

edited

Loading

JhonArlex commented Jun 27, 2019 •

edited

Loading

qortex commented Jun 28, 2019 •

edited

Loading