Skip to content

Deprecate styles and script lazy option in favor of a more self descriptive option #14814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alan-agius4 opened this issue Jun 18, 2019 · 4 comments · Fixed by #14955
Closed
Assignees
Labels
area: @angular-devkit/build-angular feature Issue that requests a new feature
Milestone

Comments

@alan-agius4
Copy link
Collaborator

🚀 Feature request

Description

The lazy option inside the script and style option is confusing as this option doesn't lazy load a bundle but rather it doesn't inject/reference the script in the HTML. While this option is an enabler for lazy loading, the users will still need to handle on how how this bundle will be lazy loaded. There are also potential use cases beyond lazy loading for the option.

Deprecate the lazy option in favour of a more self descriptive options such as injected.

@alan-agius4 alan-agius4 added needs: discussion On the agenda for team meeting to determine next steps area: @angular-devkit/build-angular labels Jun 18, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jun 18, 2019
@alan-agius4
Copy link
Collaborator Author

@filipesilva any thoughts about the above? We discussed this in our meeting and myself, @mgechev and @clydin all think it's best to deprecate lazy.

We didn't yet decide the name of the new option though, May it can be inject or injected?

@filipesilva
Copy link
Contributor

Deprecation+migration on 9 SGTM. I have no opinion on inject vs injected, I guess it's a consistency thing.

Looking at extractCss and extractLicenses it sounds like it should be inject. But then we have optimization that makes me think injected would be better. So maybe we just need to decide what tense we want for options and stick to it.

@filipesilva filipesilva removed the needs: discussion On the agenda for team meeting to determine next steps label Jun 27, 2019
@filipesilva
Copy link
Contributor

Discussed and decided on inject.

@alan-agius4 alan-agius4 self-assigned this Jun 27, 2019
@alan-agius4 alan-agius4 added the feature Issue that requests a new feature label Jun 27, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jun 27, 2019
vikerman pushed a commit that referenced this issue Jul 2, 2019
…zy` option in favor of`inject`

The lazy option inside the script and style option is confusing as this option doesn't lazy load a bundle but rather it doesn't inject/reference the script in the HTML. While this option is an enabler for lazy loading, the users will still need to handle on how how this bundle will be lazy loaded. There are also potential use cases beyond lazy loading for the option.

Closes #14814
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular-devkit/build-angular feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants