Skip to content

Build Optimizer is not wrapping some enums #14786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filipesilva opened this issue Jun 15, 2019 · 2 comments · Fixed by #14810
Closed

Build Optimizer is not wrapping some enums #14786

filipesilva opened this issue Jun 15, 2019 · 2 comments · Fixed by #14810

Comments

@filipesilva
Copy link
Contributor

The follow enum (present in RxJS):

export enum NotificationKind {
  NEXT = 'N',
  ERROR = 'E',
  COMPLETE = 'C',
}

Is transpiled by TS 3.5 to:

export var NotificationKind;
(function (NotificationKind) {
    NotificationKind["NEXT"] = "N";
    NotificationKind["ERROR"] = "E";
    NotificationKind["COMPLETE"] = "C";
})(NotificationKind || (NotificationKind = {}));

Running it through Build Optimizer leaves it unaltered, but it should be wrapped by https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_optimizer/src/transforms/wrap-enums.ts.

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Jun 15, 2019

@filipesilva, I don't think this is a regression but rather something which was never handled. wrap-enums doesn't handle string enums yet.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants