ng generate web-worker breaks tsconfig.app.json #14776

ErwSim · 2019-06-14T09:24:00Z

🐞 Bug report

Command (mark with an `x`)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [x] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

Yes, the previous version in which this bug was not present was: ....

Haven't tried web workers before so I do not known

Description

A clear and concise description of the problem...

When I generate a web worker the file tsconfig.app.json is broken
Here is the file generated

{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "outDir": "../out-tsc/app",
    "types": []
  },
  "exclude": ["test.ts", "**/*.spec.ts",]    "src/**/*.worker.ts"

}

🔬 Minimal Reproduction

ng generate web-worker save/stat-period/stat-period
CREATE tsconfig.worker.json (212 bytes)
CREATE src/app/save/stat-period/stat-period.worker.ts (157 bytes)
UPDATE src/tsconfig.app.json (180 bytes)
UPDATE angular.json (4228 bytes)
UPDATE src/app/save/stat-period/stat-period.component.ts (11072 bytes)

🔥 Exception or Error




ng serve --proxy-config proxy.conf.json 
src/tsconfig.app.json(7,46): error TS1005: ',' expected.

Error: src/tsconfig.app.json(7,46): error TS1005: ',' expected.

    at AngularCompilerPlugin._setupOptions (/home/erwan/Projets/SaveTrack/st-angular/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:95:19)
    at new AngularCompilerPlugin (/home/erwan/Projets/SaveTrack/st-angular/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:54:14)
    at _createAotPlugin (/home/erwan/Projets/SaveTrack/st-angular/node_modules/@angular-devkit/build-angular/src/angular-cli-files/models/webpack-configs/typescript.js:72:12)
    at Object.getNonAotConfig (/home/erwan/Projets/SaveTrack/st-angular/node_modules/@angular-devkit/build-angular/src/angular-cli-files/models/webpack-configs/typescript.js:78:19)
    at getCompilerConfig (/home/erwan/Projets/SaveTrack/st-angular/node_modules/@angular-devkit/build-angular/src/browser/index.js:77:95)
    at /home/erwan/Projets/SaveTrack/st-angular/node_modules/@angular-devkit/build-angular/src/browser/index.js:53:9
    at /home/erwan/Projets/SaveTrack/st-angular/node_modules/@angular-devkit/build-angular/src/utils/webpack-browser-config.js:56:26
    at Array.map ()
    at generateWebpackConfig (/home/erwan/Projets/SaveTrack/st-angular/node_modules/@angular-devkit/build-angular/src/utils/webpack-browser-config.js:31:26)
    at async Object.generateBrowserWebpackConfigFromContext (/home/erwan/Projets/SaveTrack/st-angular/node_modules/@angular-devkit/build-angular/src/utils/webpack-browser-config.js:98:20)
    at async setup (/home/erwan/Projets/SaveTrack/st-angular/node_modules/@angular-devkit/build-angular/src/dev-server/index.js:70:37)

🌍 Your Environment





     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 8.0.1
Node: 12.3.1
OS: linux x64
Angular: 8.0.0
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, material, material-moment-adapter
... platform-browser, platform-browser-dynamic, router
... service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.800.1
@angular-devkit/build-angular     0.800.1
@angular-devkit/build-optimizer   0.800.1
@angular-devkit/build-webpack     0.800.1
@angular-devkit/core              8.0.1
@angular-devkit/schematics        8.0.1
@angular/cli                      8.0.1
@angular/pwa                      0.12.4
@ngtools/webpack                  8.0.1
@schematics/angular               8.0.1
@schematics/update                0.800.1
rxjs                              6.5.2
typescript                        3.4.5
webpack                           4.30.0

Anything else relevant?

The text was updated successfully, but these errors were encountered:

alan-agius4 · 2019-06-14T09:27:34Z

Hi, I am unable to replicate this issue, can you please share your tsconfig.app.json before the update?

Thanks.

ErwSim · 2019-06-14T09:29:53Z

Sure, here it is

{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "outDir": "../out-tsc/app",
    "types": []
  },
  "exclude": [
    "test.ts",
    "**/*.spec.ts"
  ]
}

ErwSim · 2019-06-14T09:30:50Z

(I updated it for the format it really had)

alan-agius4 · 2019-06-14T09:32:58Z

Managed to replicate this if the exclude is in a single line ie:

{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "outDir": "../out-tsc/app",
    "types": []
  },
  "exclude": ["test.ts", "**/*.spec.ts"]
}

ErwSim · 2019-06-14T09:36:50Z

I just tried to add "src/**/*.worker.ts" in the exclude and if I run ng serve I have

ng serve --proxy-config proxy.conf.json 
                                                                                              
Date: 2019-06-14T09:35:37.040Z
Hash: e638712da3e53497111b
Time: 11287ms
chunk {main} main.js, main.js.map (main) 1.91 kB [initial] [rendered]
chunk {polyfills} polyfills.js, polyfills.js.map (polyfills) 145 kB [initial] [rendered]
chunk {polyfills-es5} polyfills-es5.js, polyfills-es5.js.map (polyfills-es5) 462 kB [initial] [rendered]
chunk {runtime} runtime.js, runtime.js.map (runtime) 6.08 kB [entry] [rendered]
chunk {scripts} scripts.js, scripts.js.map (scripts) 407 kB [entry] [rendered]
chunk {styles} styles.js, styles.js.map (styles) 1.36 MB [initial] [rendered]
chunk {vendor} vendor.js, vendor.js.map (vendor) 327 kB [initial] [rendered]

ERROR in node_modules/typescript/lib/lib.dom.d.ts(25,1): error TS6200: Definitions of the following identifiers conflict with those in another file: EventListenerOrEventListenerObject, BlobPart, HeadersInit, BodyInit, RequestInfo, DOMHighResTimeStamp, CanvasImageSource, MessageEventSource, ImageBitmapSource, TimerHandler, PerformanceEntryList, VibratePattern, AlgorithmIdentifier, HashAlgorithmIdentifier, BigInteger, NamedCurve, GLenum, GLboolean, GLbitfield, GLint, GLsizei, GLintptr, GLsizeiptr, GLuint, GLfloat, GLclampf, TexImageSource, Float32List, Int32List, BufferSource, DOMTimeStamp, FormDataEntryValue, IDBValidKey, Transferable, BinaryType, ClientTypes, EndingType, IDBCursorDirection, IDBRequestReadyState, IDBTransactionMode, KeyFormat, KeyType, KeyUsage, NotificationDirection, NotificationPermission, PushEncryptionKeyName, PushPermissionState, ReferrerPolicy, RequestCache, RequestCredentials, RequestDestination, RequestMode, RequestRedirect, ResponseType, ServiceWorkerState, ServiceWorkerUpdateViaCache, VisibilityState, WebGLPowerPreference, WorkerType, XMLHttpRequestResponseType
node_modules/typescript/lib/lib.dom.d.ts(3473,5): error TS2687: All declarations of 'privateKey' must have identical modifiers.
node_modules/typescript/lib/lib.dom.d.ts(3474,5): error TS2687: All declarations of 'publicKey' must have identical modifiers.
node_modules/typescript/lib/lib.webworker.d.ts(25,1): error TS6200: Definitions of the following identifiers conflict with those in another file: EventListenerOrEventListenerObject, BlobPart, HeadersInit, BodyInit, RequestInfo, DOMHighResTimeStamp, CanvasImageSource, MessageEventSource, ImageBitmapSource, TimerHandler, PerformanceEntryList, VibratePattern, AlgorithmIdentifier, HashAlgorithmIdentifier, BigInteger, NamedCurve, GLenum, GLboolean, GLbitfield, GLint, GLsizei, GLintptr, GLsizeiptr, GLuint, GLfloat, GLclampf, TexImageSource, Float32List, Int32List, BufferSource, DOMTimeStamp, FormDataEntryValue, IDBValidKey, Transferable, BinaryType, ClientTypes, EndingType, IDBCursorDirection, IDBRequestReadyState, IDBTransactionMode, KeyFormat, KeyType, KeyUsage, NotificationDirection, NotificationPermission, PushEncryptionKeyName, PushPermissionState, ReferrerPolicy, RequestCache, RequestCredentials, RequestDestination, RequestMode, RequestRedirect, ResponseType, ServiceWorkerState, ServiceWorkerUpdateViaCache, VisibilityState, WebGLPowerPreference, WorkerType, XMLHttpRequestResponseType
node_modules/typescript/lib/lib.webworker.d.ts(85,5): error TS2687: All declarations of 'privateKey' must have identical modifiers.
node_modules/typescript/lib/lib.webworker.d.ts(86,5): error TS2687: All declarations of 'publicKey' must have identical modifiers.
node_modules/typescript/lib/lib.webworker.d.ts(1074,5): error TS2375: Duplicate number index signature.
node_modules/typescript/lib/lib.webworker.d.ts(1360,5): error TS2375: Duplicate number index signature.
node_modules/typescript/lib/lib.webworker.d.ts(1434,13): error TS2403: Subsequent variable declarations must have the same type.  Variable 'FormData' must be of type '{ new (form?: HTMLFormElement): FormData; prototype: FormData; }', but here has type '{ new (): FormData; prototype: FormData; }'.
node_modules/typescript/lib/lib.webworker.d.ts(2170,13): error TS2403: Subsequent variable declarations must have the same type.  Variable 'Notification' must be of type '{ new (title: string, options?: NotificationOptions): Notification; prototype: Notification; readonly maxActions: number; readonly permission: NotificationPermission; requestPermission(deprecatedCallback?: NotificationPermissionCallback): Promise<...>; }', but here has type '{ new (title: string, options?: NotificationOptions): Notification; prototype: Notification; readonly maxActions: number; readonly permission: NotificationPermission; }'.
node_modules/typescript/lib/lib.webworker.d.ts(4322,13): error TS2403: Subsequent variable declarations must have the same type.  Variable 'onmessage' must be of type '(this: Window, ev: MessageEvent) => any', but here has type '(this: DedicatedWorkerGlobalScope, ev: MessageEvent) => any'.
node_modules/typescript/lib/lib.webworker.d.ts(4332,13): error TS2403: Subsequent variable declarations must have the same type.  Variable 'location' must be of type 'Location', but here has type 'WorkerLocation'.
node_modules/typescript/lib/lib.webworker.d.ts(4333,13): error TS2403: Subsequent variable declarations must have the same type.  Variable 'onerror' must be of type 'OnErrorEventHandlerNonNull', but here has type '(this: DedicatedWorkerGlobalScope, ev: ErrorEvent) => any'.
node_modules/typescript/lib/lib.webworker.d.ts(4335,13): error TS2403: Subsequent variable declarations must have the same type.  Variable 'self' must be of type 'Window', but here has type 'WorkerGlobalScope'.
node_modules/typescript/lib/lib.webworker.d.ts(4344,13): error TS2403: Subsequent variable declarations must have the same type.  Variable 'navigator' must be of type 'Navigator', but here has type 'WorkerNavigator'.

** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **
ℹ ｢wdm｣: Failed to compile.

Should I open a new issue ?

alan-agius4 · 2019-06-14T11:32:02Z

@ErwSim, yes please and kindly share a minimal repo.
Thanks

splincode · 2019-06-25T12:18:08Z

Also when I generated web worker I see
WARNING in new Worker() will only be bundled if passed a String

christianlundberg · 2019-07-10T22:00:49Z

I managed to fix it by correcting the "exclude" array, but then I immediately started seeing the same warning as @splincode

stephanrauh · 2019-07-11T20:03:32Z

Anybody working on this ticket? I've managed to reproduce the bug with the current version of https://github.com/stephanrauh/extended-pdf-viewer-showcase. Just clone it, run ng generate web-worker save/stat-period/stat-period, and have a look at the tsconfig.app.json.

jcjolley · 2019-07-31T20:02:12Z

This doesn't cause the WARNING in new Worker() will only be bundled if passed a String warning:

const myWorker = new Worker('my-worker.worker', {type: 'module'})

This does:

const workerName: string = 'my-worker.worker'
const myWorker =  new Worker(workerName', {type: 'module'})

playground · 2019-10-17T01:46:31Z

I'm seeing the same issue.

WARNING in new Worker() will only be bundled if passed a String.

`Angular CLI: 8.3.0
Node: 11.15.0
OS: darwin x64
Angular: 8.2.3
... animations, common, compiler, compiler-cli, core, elements
... forms, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker

Package Version

@angular-devkit/architect 0.800.6
@angular-devkit/build-angular 0.800.6
@angular-devkit/build-ng-packagr 0.800.6
@angular-devkit/build-optimizer 0.800.6
@angular-devkit/build-webpack 0.800.6
@angular-devkit/core 8.0.6
@angular-devkit/schematics 8.3.0
@angular/cdk 8.1.3
@angular/cli 8.3.0
@angular/flex-layout 8.0.0-beta.26
@angular/material 8.1.3
@ngtools/webpack 8.0.6
@nguniversal/express-engine 8.1.1
@nguniversal/module-map-ngfactory-loader 8.1.1
@schematics/angular 8.3.0
@schematics/update 0.803.0
ng-packagr 5.5.0
rxjs 6.5.2
typescript 3.4.5
webpack 4.30.0`

akphi · 2019-10-25T04:25:04Z

I think this is a problem with work-plugin though I'm not 100% sure if this is what cli uses internally but I have found that warning line their source code. Also they have an issue that has been going on for a year now. We should probably move the discussion over there.

…ON when using different formatting Fixes: #16024, fixes: #15462 and fixes: #14776

angular-automatic-lock-bot · 2019-12-07T08:01:20Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alan-agius4 added the needs: repro steps We cannot reproduce the issue with the information given label Jun 14, 2019

alan-agius4 added area: @schematics/angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix and removed needs: repro steps We cannot reproduce the issue with the information given labels Jun 14, 2019

ngbot bot modified the milestone: Backlog Jun 14, 2019

alan-agius4 mentioned this issue Jul 10, 2019

Invalid tsconfig.app.json after generating web worker #15037

Closed

jiverson mentioned this issue Jul 11, 2019

Getting window.webViewerLoad is not a function stephanrauh/ngx-extended-pdf-viewer#20

Closed

alan-agius4 mentioned this issue Nov 4, 2019

Build fails with "Unexpected token ] in JSON" after updating to version 9 #16024

Closed

alan-agius4 self-assigned this Nov 4, 2019

alan-agius4 mentioned this issue Nov 5, 2019

fix(@schematics/angular): appendValueInAstArray should not break JS… #16062

Merged

vikerman closed this as completed in #16062 Nov 6, 2019

vikerman pushed a commit that referenced this issue Nov 6, 2019

fix(@schematics/angular): appendValueInAstArray should not break JS…

26f5e6f

…ON when using different formatting Fixes: #16024, fixes: #15462 and fixes: #14776

vikerman pushed a commit that referenced this issue Nov 6, 2019

fix(@schematics/angular): appendValueInAstArray should not break JS…

a9bee14

…ON when using different formatting Fixes: #16024, fixes: #15462 and fixes: #14776

angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ng generate web-worker breaks tsconfig.app.json #14776

ng generate web-worker breaks tsconfig.app.json #14776

ErwSim commented Jun 14, 2019 •

edited

Loading

alan-agius4 commented Jun 14, 2019

ErwSim commented Jun 14, 2019 •

edited

Loading

ErwSim commented Jun 14, 2019

alan-agius4 commented Jun 14, 2019

ErwSim commented Jun 14, 2019 •

edited

Loading

alan-agius4 commented Jun 14, 2019

splincode commented Jun 25, 2019

christianlundberg commented Jul 10, 2019

stephanrauh commented Jul 11, 2019

jcjolley commented Jul 31, 2019 •

edited

Loading

playground commented Oct 17, 2019 •

edited

Loading

akphi commented Oct 25, 2019

angular-automatic-lock-bot bot commented Dec 7, 2019

ng generate web-worker breaks tsconfig.app.json #14776

ng generate web-worker breaks tsconfig.app.json #14776

Comments

ErwSim commented Jun 14, 2019 • edited Loading

🐞 Bug report

Command (mark with an x)

Is this a regression?

Description

🔬 Minimal Reproduction

🔥 Exception or Error

🌍 Your Environment

alan-agius4 commented Jun 14, 2019

ErwSim commented Jun 14, 2019 • edited Loading

ErwSim commented Jun 14, 2019

alan-agius4 commented Jun 14, 2019

ErwSim commented Jun 14, 2019 • edited Loading

alan-agius4 commented Jun 14, 2019

splincode commented Jun 25, 2019

christianlundberg commented Jul 10, 2019

stephanrauh commented Jul 11, 2019

jcjolley commented Jul 31, 2019 • edited Loading

playground commented Oct 17, 2019 • edited Loading

Package Version

akphi commented Oct 25, 2019

angular-automatic-lock-bot bot commented Dec 7, 2019

ErwSim commented Jun 14, 2019 •

edited

Loading

Command (mark with an `x`)

ErwSim commented Jun 14, 2019 •

edited

Loading

ErwSim commented Jun 14, 2019 •

edited

Loading

jcjolley commented Jul 31, 2019 •

edited

Loading

playground commented Oct 17, 2019 •

edited

Loading