-
Notifications
You must be signed in to change notification settings - Fork 12k
Ng 8.0 + ivy + library Error : does not have 'ngModuleDef' property #14594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Libraries outside of |
oic, any road map for this feature ? |
@manughub could this be moved to |
I've moved this issue to the CLI repo. We don't yet have good support for Ivy libraries in the CLI. |
Hi @keatkeat87, yes this is something in the roadmap to add ngcc processing on workspace libraries. We are targeting this for 8.1 Thanks |
This comment has been minimized.
This comment has been minimized.
In version 8.1, similar to TypeScript Compiler, NGCC supports Path Mappings. This enable NGCC to process workspace libraries similar to what it is currently being done for `node_modules` Closes #14594
Going to re-open this as it's seems that it is not fully resolved |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In version 8.1, similar to TypeScript Compiler, NGCC supports Path Mappings. This enable NGCC to process workspace libraries similar to what it is currently being done for `node_modules` Closes angular#14594
🐞 bug report
Is this a regression?
no
Description
this is a simple test ng 8.0 + ivy + library. is it ivy supported custom library ?
this is the error message i get :
Error: Type MyLibModule does not have 'ngModuleDef' property.
if i turn off ivy, all work fine
🔬 Minimal Reproduction
https://github.com/keatkeat87/angular-ivy-library-issue
step :
ng new library-and-project-issue --enable-ivy
cd library-and-project-issue
ng g library my-lib
ng build my-lib
ng serve --open
Angular Version:
Angular CLI: 8.0.0
Node: 12.3.1
OS: win32 x64
Angular:
...
Package Version
@angular-devkit/architect 0.800.0
@angular-devkit/core 8.0.0
@angular-devkit/schematics 8.0.0
@schematics/angular 8.0.0
@schematics/update 0.800.0
rxjs 6.4.0
The text was updated successfully, but these errors were encountered: