Cannot update to 8 without --force when there are existing peerDep warnings for Angular #14562

filipesilva · 2019-05-29T13:15:04Z

@johnpapa tried to update https://github.com/johnpapa/angular-event-view-cli to version 8 but ran into some problems related to peer dependencies.

You can reproduce the starting state by following these commands:

git clone https://github.com/johnpapa/angular-event-view-cli
cd angular-event-view-cli
git checkout 437ebea5b099a7a8e24bbcd0ed14938b3183a1f5

At this point running npm i will show some peer dependency warnings:

kamik@RED-X1C6 MINGW64 /d/sandbox/angular-event-view-cli (master)
$ npm i
npm WARN [email protected] requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of ajv@^6.9.1 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/common@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/http@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/compiler@>=2.3.1 <7.0.0 || >6.0.0-beta <7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@>=2.3.1 <7.0.0 || >6.0.0-beta <7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/platform-browser-dynamic@>=2.3.1 <7.0.0 || >6.0.0-beta <7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/platform-browser@>=2.3.1 <7.0.0 || >6.0.0-beta <7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/common@>=2.3.1 <7.0.0 || >6.0.0-beta <7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of jasmine-core@>=3.3 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\@angular\compiler-cli\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

audited 45000 packages in 9.25s
found 0 vulnerabilities

These warnings say that angular-in-memory-web-api and codelyzer do not support Angular version 7, which is currently used on the project.

Trying to update to 8 at this stage will not work:

kamik@RED-X1C6 MINGW64 /d/sandbox/angular-event-view-cli (master)
$ ng update @angular/core @angular/cli
                  Package "codelyzer" has an incompatible peer dependency to "@angular/compiler" (requires ">=2.3.1 <7.0.0 || >6.0.0-beta <7.0.0" (extended), would install "8.0.0").
                  Package "codelyzer" has an incompatible peer dependency to "@angular/core" (requires ">=2.3.1 <7.0.0 || >6.0.0-beta <7.0.0" (extended), would install "8.0.0").
                  Package "codelyzer" has an incompatible peer dependency to "@angular/platform-browser" (requires ">=2.3.1 <7.0.0 || >6.0.0-beta <7.0.0" (extended), would install "8.0.0").
                  Package "codelyzer" has an incompatible peer dependency to "@angular/common" (requires ">=2.3.1 <7.0.0 || >6.0.0-beta <7.0.0" (extended), would install "8.0.0").
                  Package "codelyzer" has an incompatible peer dependency to "@angular/platform-browser-dynamic" (requires ">=2.3.1 <7.0.0 || >6.0.0-beta <7.0.0" (extended), would install "8.0.0").  
Incompatible peer dependencies found. See above.

To enable the update, all peerDependency for Angular must be resolved prior to the update.

kamik@RED-X1C6 MINGW64 /d/sandbox/angular-event-view-cli (master)
$ npm i --save-dev [email protected]
npm WARN [email protected] requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of ajv@^6.9.1 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/common@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/http@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of jasmine-core@>=3.3 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\@angular\compiler-cli\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

+ [email protected]
added 1 package from 1 contributor, updated 2 packages and audited 45000 packages in 9.327s
found 0 vulnerabilities


kamik@RED-X1C6 MINGW64 /d/sandbox/angular-event-view-cli (master)
$ ng update @angular/core @angular/cli
                  Package "angular-in-memory-web-api" has an incompatible peer dependency to "@angular/common" (requires "^6.0.0" (extended), would install "8.0.0").
                  Package "angular-in-memory-web-api" has an incompatible peer dependency to "@angular/core" (requires "^6.0.0" (extended), would install "8.0.0").
Incompatible peer dependencies found. See above.

kamik@RED-X1C6 MINGW64 /d/sandbox/angular-event-view-cli (master)
$ npm i [email protected]
npm WARN [email protected] requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of ajv@^6.9.1 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of jasmine-core@>=3.3 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\@angular\compiler-cli\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

+ [email protected]
updated 1 package and audited 45000 packages in 9.027s
found 0 vulnerabilities


kamik@RED-X1C6 MINGW64 /d/sandbox/angular-event-view-cli (master)
$ ng update @angular/core @angular/cli
    Updating package.json with dependency @angular/compiler-cli @ "8.0.0" (was "7.2.15")...
    Updating package.json with dependency @angular/cli @ "8.0.0" (was "7.3.9")...
    Updating package.json with dependency @angular/animations @ "8.0.0" (was "7.2.15")...
    Updating package.json with dependency @angular/compiler @ "8.0.0" (was "7.2.15")...
    Updating package.json with dependency @angular/common @ "8.0.0" (was "7.2.15")...
    Updating package.json with dependency @angular/language-service @ "8.0.0" (was "7.2.15")...
    Updating package.json with dependency @angular/forms @ "8.0.0" (was "7.2.15")...
    Updating package.json with dependency @angular/core @ "8.0.0" (was "7.2.15")...
    Updating package.json with dependency @angular/platform-browser @ "8.0.0" (was "7.2.15")...
    Updating package.json with dependency zone.js @ "0.9.1" (was "0.8.29")...
    Updating package.json with dependency @angular/platform-browser-dynamic @ "8.0.0" (was "7.2.15")...
    Updating package.json with dependency @angular/router @ "8.0.0" (was "7.2.15")...
    Updating package.json with dependency @angular/platform-server @ "8.0.0" (was "7.2.15")...
    Updating package.json with dependency @angular-devkit/build-angular @ "0.800.0" (was "0.13.9")...
    Updating package.json with dependency typescript @ "3.4.5" (was "3.2.4")...
UPDATE package.json (2143 bytes)

> @angular/[email protected] postinstall D:\sandbox\angular-event-view-cli\node_modules\@angular\cli
> node ./bin/postinstall/script.js

npm WARN @angular/[email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/common@>=6.0.0 <8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@>=6.0.0 <8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/compiler@>=2.3.1 <8.0.0 || >7.0.0-beta <8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@>=2.3.1 <8.0.0 || >7.0.0-beta <8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of jasmine-core@>=3.3 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of ajv@^6.9.1 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\webpack-dev-server\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\@angular\compiler-cli\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

added 49 packages from 31 contributors, removed 130 packages, updated 122 packages, moved 6 packages and audited 21390 packages in 57.78s
found 0 vulnerabilities

    ** Executing migrations for package '@angular/core' **
            ------ Static Query Migration ------
            With Angular version 8, developers need to
            explicitly specify the timing of ViewChild and
            ContentChild queries. Read more about this here:
            https://v8.angular.io/guide/static-query-migration
            ------------------------------------------------
UPDATE src/app/sessions/session-list/session-list.component.ts (1766 bytes)
UPDATE src/app/speakers/speaker-list/speaker-list.component.ts (1529 bytes)
    ** Executing migrations for package '@angular/cli' **
CREATE browserslist (429 bytes)
UPDATE tslint.json (2541 bytes)
UPDATE package.json (2113 bytes)
UPDATE src/polyfills.ts (2393 bytes)
UPDATE tsconfig.json (439 bytes)
UPDATE src/tsconfig.app.json (211 bytes)
UPDATE src/tsconfig.spec.json (274 bytes)
npm WARN [email protected] requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of ajv@^6.9.1 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/common@>=6.0.0 <8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@>=6.0.0 <8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/http@>=6.0.0 <8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of jasmine-core@>=3.3 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\webpack-dev-server\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\@angular\compiler-cli\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

added 4 packages from 7 contributors, removed 1 package, updated 1 package and audited 21394 packages in 11.176s
found 0 vulnerabilities

The update would also have ran if --force was used, but the user was never informed of that. Perhaps if we had mentioned that on the original error message, it would have been easier from the start. But even better than that would be to also explain the peer dependency problem better.

The text was updated successfully, but these errors were encountered:

filipesilva · 2019-05-29T13:16:26Z

It also happened in this update that the lazy routes where not updated to import(): johnpapa/angular-event-view-cli@7d2c125#diff-959f71d9b4ce6d41e637aaf363c42a18

That's because we look for loadChildren: "path/to/module#export" but instead this project had an object with a bunch of paths inside, then referenced it.

johnpapa · 2019-05-29T13:26:23Z

One difference for me

I ran

ng update codelyzer

ng update angular-in-memory-web-api

…ble peer dependencies fix #14562

angular-automatic-lock-bot · 2019-09-09T14:41:59Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

filipesilva added type: bug/fix freq3: high severity1: confusing comp: schematics/update labels May 29, 2019

filipesilva added this to the 8.0.1 milestone May 29, 2019

alan-agius4 mentioned this issue May 30, 2019

fix(@schematics/update): improve error message when finding incompati… #14578

Merged

alan-agius4 self-assigned this May 30, 2019

alexeagle closed this as completed in #14578 May 30, 2019

alexeagle pushed a commit that referenced this issue May 30, 2019

fix(@schematics/update): improve error message when finding incompati…

5a100c7

…ble peer dependencies fix #14562

alexeagle pushed a commit that referenced this issue May 30, 2019

fix(@schematics/update): improve error message when finding incompati…

231afee

…ble peer dependencies fix #14562

wy193777 mentioned this issue Aug 10, 2019

ng update doesn't work every single time #15296

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot update to 8 without --force when there are existing peerDep warnings for Angular #14562

Cannot update to 8 without --force when there are existing peerDep warnings for Angular #14562

filipesilva commented May 29, 2019

filipesilva commented May 29, 2019

johnpapa commented May 29, 2019

angular-automatic-lock-bot bot commented Sep 9, 2019

Cannot update to 8 without --force when there are existing peerDep warnings for Angular #14562

Cannot update to 8 without --force when there are existing peerDep warnings for Angular #14562

Comments

filipesilva commented May 29, 2019

filipesilva commented May 29, 2019

johnpapa commented May 29, 2019

angular-automatic-lock-bot bot commented Sep 9, 2019