Order of parameters not preserved when using x-prompt

[Wintermoose]

🐞 Bug report

Command (mark with an x)

- [X] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [X] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description

When Angular CLI is asking for parameters specified with x-prompt in a schematics, the order should be preserved. This seems to be true for small number of prompts, but breaks when more are used.

The likely culprit is the sort on top of _applyPrompts in https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/core/src/json/schema/registry.ts

It seems that older V8 versions didn't implement stable sort. I don't follow exactly the Node releases, so it's possible this is fixed in the absolutely newest one.

Seeing that the priorities are currently not configurable, maybe commenting-out the sort call is the quickest fix.

🔬 Minimal Reproduction

• define schema.json with larger number of parameters and x-prompt (our is currently using 13)
• run ng new or ng generate without providing the parameters, thus triggering the interactive prompts

🌍 Your Environment

Angular CLI: 7.3.8
Node: 10.15.3
OS: win32 x64
Angular:
...

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.13.8
@angular-devkit/core         7.3.8
@angular-devkit/schematics   7.3.8
@schematics/angular          7.3.8
@schematics/update           0.13.8
rxjs                         6.3.3
typescript                   3.2.4

[clydin]

The versions of V8 used within Node.js 10 and earlier use an unstable quicksort for arrays with a length larger than 10. Node.js 11/12+ use V8 7.0+ which implements a stable sort instead.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}