Skip to content

v8 Migration adds browserlist for non-angular apps #14389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FrozenPandaz opened this issue May 9, 2019 · 1 comment · Fixed by #14411
Closed

v8 Migration adds browserlist for non-angular apps #14389

FrozenPandaz opened this issue May 9, 2019 · 1 comment · Fixed by #14411

Comments

@FrozenPandaz
Copy link
Contributor

FrozenPandaz commented May 9, 2019

🐞 Bug report

Scope

v8 Browerlist migration

Is this a regression?

No, this is an enhancement to current behavior

Description

Currently, the v8 migration produces a browserlist file for every application. This should be filtered to applications which use @angular-devkit/build-angular:browser.

🔬 Minimal Reproduction

npx -p @nrwl/schematics@latest create-nx-workspace fullstack-ws --preset full-stack --no-interactive
cd fullstack-ws
ng update @angular/cli @angular/core --next --force

## 🔥 Issue

`apps/api/browserslist` is created which is a backend project which does not need Differential Loading.

## Expected Behavior

`browserlist` should only be created for projects which use `@angular-devkit/build-angular:browser` for at least one of their targets.

cc @filipesilva

## 🌍 Your Environment
Fullstack workspace
@ngbot ngbot bot added this to the Backlog milestone May 9, 2019
@filipesilva filipesilva modified the milestones: Backlog, 8.0 May 9, 2019
@alan-agius4 alan-agius4 self-assigned this May 13, 2019
kyliau pushed a commit that referenced this issue May 13, 2019
…nly for projects using `@angular-devkit/build-angular:browser`

Differential loading migration should run only when the project is using `@angular-devkit/build-angular:browser` as it's browser builder. Otherwise we might break applications that are using different builders.

Fixes #14389
kyliau pushed a commit that referenced this issue May 13, 2019
…nly for projects using `@angular-devkit/build-angular:browser`

Differential loading migration should run only when the project is using `@angular-devkit/build-angular:browser` as it's browser builder. Otherwise we might break applications that are using different builders.

Fixes #14389
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants