Skip to content

tsconfig with comments breaks ng add @nguniversal/express-engine #14371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ionaru opened this issue May 8, 2019 · 1 comment · Fixed by #14372
Closed

tsconfig with comments breaks ng add @nguniversal/express-engine #14371

Ionaru opened this issue May 8, 2019 · 1 comment · Fixed by #14372
Assignees
Labels
area: @schematics/angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Milestone

Comments

@Ionaru
Copy link

Ionaru commented May 8, 2019

🐞 Bug report

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [x] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description

A tsconfig.app.json file with comments will cause ng add @nguniversal/express-engine to error after installing @nguniversal/express-engine.

🔬 Minimal Reproduction

  1. ng new myApp
  2. Enter through all questions (use defaults)
  3. cd myApp
  4. Edit tsconfig.app.json and add a comment anywhere in the file.
  5. ng add @nguniversal/express-engine --clientProject myApp

🔥 Exception or Error

Invalid JSON character: "S" at 2:4.

🌍 Your Environment

Angular CLI: 7.3.9
Node: 12.1.0
OS: linux x64
Angular: 7.2.15
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.13.9
@angular-devkit/build-angular     0.13.9
@angular-devkit/build-optimizer   0.13.9
@angular-devkit/build-webpack     0.13.9
@angular-devkit/core              7.3.9
@angular-devkit/schematics        7.3.9
@angular/cli                      7.3.9
@ngtools/webpack                  7.3.9
@schematics/angular               7.3.9
@schematics/update                0.13.9
rxjs                              6.3.3
typescript                        3.2.4
webpack                           4.29.0

Anything else relevant?

TypeScript has allowed comments in tsconfig files since microsoft/TypeScript#5450 was merged.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @schematics/angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants