-
Notifications
You must be signed in to change notification settings - Fork 12k
xi18n doesn't emit messages.xlf with Ivy enabled #14225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @ocombe as you may have an idea? |
@cexbrayat I don't think xi18n works with ivy yet |
@AndrewKushnir you told me the other day that it was supposed to work with ivy right now, can you take a look at it please? |
@ocombe sorry for the delay in answering. Ivy uses different code to process i18n-related attributes/blocks. The code of existing extraction/merging tools (based on View Engine) is not affected by Ivy changes, so these tools should continue to run without any changes. |
I added a ticket on Jira to track this |
xi18n doesn't emit messages.xlf with Ivy enabled (same problem with)
|
…18n in Ivy i18n is not yet implemented in Ivy, we should emit a warning stating this and exit gracefully. This also swaps the readTsConfig logic to use `@angular/compiler-cli` instead of `typescript`. This is needed because when parsing the tsconfig, typescript is not aware of `angularCompilerOptions` and will not merged them if they are at un upper level tsconfig file when using `extends`. Closes #14225
…18n in Ivy i18n is not yet implemented in Ivy, we should emit a warning stating this and exit gracefully. This also swaps the readTsConfig logic to use `@angular/compiler-cli` instead of `typescript`. This is needed because when parsing the tsconfig, typescript is not aware of `angularCompilerOptions` and will not merged them if they are at un upper level tsconfig file when using `extends`. Closes #14225
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
🐞 Bug report
Command (mark with an
x
)Is this a regression?
The issue is only present with Ivy enabled
Description
Running
ng xi18n
does not emitmessages.xlf
if the app uses Ivy.🔬 Minimal Reproduction
🔥 Exception or Error
No error can be seen, the command runs OK:
But not file is emitted.
If you switch
enableIvy
tofalse
, then the command emitsmessages.xlf
again.🌍 Your Environment
The text was updated successfully, but these errors were encountered: