Skip to content

@angular-devkit/[email protected] breaks ng e2e --prod when budget #14100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mboughaba opened this issue Apr 7, 2019 · 1 comment · Fixed by #14103
Closed

@angular-devkit/[email protected] breaks ng e2e --prod when budget #14100

mboughaba opened this issue Apr 7, 2019 · 1 comment · Fixed by #14103
Labels
Milestone

Comments

@mboughaba
Copy link

🐞 Bug report

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [x] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

Yes

Yes, the previous version in which this bug was not present was: 0.12.4

Description

A clear and concise description of the problem...

after upgrading to @angular-devkit/[email protected], ng e2e --prod stopped working.
In angular/cli we setup budgets with maximumWarning and maximumError.

When running ng e2e --prod --port 4201 the budget errors out and the build/serve which should be triggered by ng n2e fails.

We get error in budget because e2e production build is not at the same level of optimization as the real production build.

🔬 Minimal Reproduction

🔥 Exception or Error




failed to compile

🌍 Your Environment




λ ng version                                                           
                                                                       
     _                      _                 ____ _     ___           
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|          
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |           
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |           
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|          
                |___/                                                  
                                                                       
                                                                       
Angular CLI: 7.3.7                                                     
Node: 11.13.0                                                          
OS: win32 x64                                                          
Angular: 7.2.11                                                        
... common, compiler, compiler-cli, core, forms, http                  
... language-service, platform-browser, platform-browser-dynamic       
                                                                       
Package                           Version                              
-----------------------------------------------------------            
@angular-devkit/architect         0.13.7                               
@angular-devkit/build-angular     0.13.8                               
@angular-devkit/build-optimizer   0.13.8                               
@angular-devkit/build-webpack     0.12.4                               
@angular-devkit/core              7.3.7                                
@angular-devkit/schematics        7.3.7                                
@angular/cli                      7.3.7                                
@ngtools/webpack                  7.3.8                                
@schematics/angular               7.3.7                                
@schematics/update                0.13.7                               
rxjs                              6.4.0                                
typescript                        3.2.4                                
webpack                           4.6.0                                
                                                                       

Anything else relevant?

@mboughaba mboughaba changed the title @angular-devkit/[email protected] breaks ng e2e --prod @angular-devkit/[email protected] breaks ng e2e --prod when budget Apr 7, 2019
@alan-agius4 alan-agius4 added area: @angular-devkit/build-angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken labels Apr 8, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 8, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Apr 8, 2019
alexeagle pushed a commit that referenced this issue Apr 12, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants