`import as` results in the alias being undefined with Typescript 3.2 #13212

IgorMinar · 2018-12-18T05:49:01Z

Bug Report or Feature Request (mark with an `x`)

- [x] bug report -> please search issues before submitting

Command (mark with an `x`)

- [x] serve
- [x] e2e

Versions

Angular CLI: 7.1.3
Node: 10.11.0
OS: darwin x64
Angular: 7.2.0-beta.2+55.sha-a6e6763
... animations, common, compiler, compiler-cli, core, elements
... forms, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.10.7
@angular-devkit/build-angular     0.10.7
@angular-devkit/build-optimizer   0.10.7
@angular-devkit/build-webpack     0.10.7
@angular-devkit/core              7.1.3
@angular-devkit/schematics        7.1.3
@angular/cdk                      7.0.0
@angular/cli                      7.1.3
@angular/material                 7.0.0
@ngtools/webpack                  7.0.7
@schematics/angular               7.1.3
@schematics/update                0.11.3
rxjs                              6.3.3
typescript                        3.2.2
webpack                           4.19.1

Repro steps

After typescript 3.2 upgrade, I've started seeing e2e test failures due to certain symbols not being defined - in all cases these symbols came from rxjs and were aliased to a different name.

The problem occurs during dev builds without optimizations turned on and causes both ng serve and ng e2e to fail with runtime errors in the browser

For example:

import { from as fromPromise, Observable } from 'rxjs';

Would end up with fromPromise being undefined at runtime.

Workarounds

remove the as alias and refactor the code to use the original symbol name.
revert back to typescript 3.1

More info

I'll try to create a minimal reproduction outside of aio but for now you can review the "workaround" commit in https://github.com/angular/angular/pull/27536/commits

In the meantime I've tested the as imports in vanilla tsc and it seems to be working just fine there, so I suspect that it's some kind of interaction with cli or webpack that is causing this.

The text was updated successfully, but these errors were encountered:

It's unclear why `import as` results in the aliases to be undefined. Plain tsc seems to do the right thing and emits the correct code, so it might be some kind of interaction in @angular/cli or webpack that are causing the failure. This should be investigated separately from the tsc update in angular/angular. See angular/angular-cli#13212

IgorMinar · 2018-12-18T06:15:39Z

hmm.. unfortunately I can't seem to be able to reproduce this outside of angular.io... in aio it's quite easy to repro this, but I don't know what makes aio special.

It's unclear why `import as` results in the aliases to be undefined. Plain tsc seems to do the right thing and emits the correct code, so it might be some kind of interaction in @angular/cli or webpack that are causing the failure. This should be investigated separately from the tsc update in angular/angular. See angular/angular-cli#13212

thw0rted · 2018-12-18T14:12:25Z

I have spent all day tearing my hair out trying to nail this down... I'm glad to see I'm not alone. I also haven't been able to make a lightweight reproduction yet -- I have a lot of moving pieces in my (broken) build and thought it might have been some interaction between webpack, the DLL/DLLReference plugins, and the AOT compiler. I just finally figured out that it must be something to do with @ngtools/webpack because I couldn't get the error to happen without it.

I'm going to spend a little more time trying to make a compact reproduction but if it's impossible to build core Angular as-is under TS 3.2, that's probably good enough to make sure it gets addressed. I just hope we don't spend too long with "workarounds" like taking out aliasing completely. I don't just use those as a nice-to-have, I have a dependency where they export a variable I need called "Math"... and I need to access the actual Math object in the same place. As far as I can tell I don't really have any recourse other than aliasing (or renaming the global Math somewhere, which is definitely worse).

thw0rted · 2018-12-18T14:26:08Z

Just noticed that this corresponds with a change in import-alias behavior in a recent VSCode version, and I'm wondering if there's some connection? See e.g. this issue.

alan-agius4 · 2018-12-18T19:40:47Z

I had a quick look at this, and it seems that this is only happening in AOT mode.

AIO is "special" because it's serve uses AOT and buildOptimizer. Running node_modules/.bin/ngc -p src/tsconfig.app.json in the AIO folder, does output the correct import as statements.

It's unclear why `import as` results in the aliases to be undefined. Plain tsc seems to do the right thing and emits the correct code, so it might be some kind of interaction in @angular/cli or webpack that are causing the failure. This should be investigated separately from the tsc update in angular/angular. See angular/angular-cli#13212 PR Close #27536

It's unclear why `import as` results in the aliases to be undefined. Plain tsc seems to do the right thing and emits the correct code, so it might be some kind of interaction in @angular/cli or webpack that are causing the failure. This should be investigated separately from the tsc update in angular/angular. See angular/angular-cli#13212 PR Close angular#27536

…ed with Typescript 3.2 When using the `specifier.propertyName` with `typeChecker.getSymbolAtLocation` it will return a more detailed symbol then we originally have in the `usedSymbols` set. We should probably use `symbol.id` to actually check if the symbols are the same, however the `id` is not exposed in the Symbol interface. Using `node.name` will return the same symbol that we have stored in the set. Fixes #13212

thw0rted · 2018-12-20T08:07:50Z

Does this issue automatically get notified when the patch is included in a published release? If not, do we have an ETA on when this might land?

This also adds the option to provide addition files when using `createTypescriptContext` this is paramount for the elide imports tests as without this certain symbols won't have the full details. Which will cause tests to be false positive and re-surface issues like #13212

IgorMinar · 2019-01-27T05:09:21Z

we usually cut patch releases every week. unfortunately we currently don't have an automated way to post a comment on an issue once the fix is released in a patch version, but that's not a bad idea. would you mind filing an issue with such request? thanks

…

On Thu, Dec 20, 2018 at 12:07 AM James Bromwell ***@***.***> wrote: Does this issue automatically get notified when the patch is included in a published release? If not, do we have an ETA on when this might land? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13212 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6N8AW2UQ9y8pbyWwaJD6BtjXdR3oks5u60VYgaJpZM4ZXpFJ> .

It's unclear why `import as` results in the aliases to be undefined. Plain tsc seems to do the right thing and emits the correct code, so it might be some kind of interaction in @angular/cli or webpack that are causing the failure. This should be investigated separately from the tsc update in angular/angular. See angular/angular-cli#13212 PR Close angular#27536

angular-automatic-lock-bot · 2019-09-09T05:41:29Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…ed with Typescript 3.2 When using the `specifier.propertyName` with `typeChecker.getSymbolAtLocation` it will return a more detailed symbol then we originally have in the `usedSymbols` set. We should probably use `symbol.id` to actually check if the symbols are the same, however the `id` is not exposed in the Symbol interface. Using `node.name` will return the same symbol that we have stored in the set. Fixes angular#13212

IgorMinar mentioned this issue Dec 18, 2018

feat: add support for typescript 3.2 angular/angular#27536

Closed

alan-agius4 added the area: @ngtools/webpack label Dec 18, 2018

ngbot bot added this to the needsTriage milestone Dec 18, 2018

alan-agius4 added type: bug/fix freq3: high severity3: broken labels Dec 18, 2018

ngbot bot modified the milestones: needsTriage, Backlog Dec 18, 2018

alan-agius4 added severity5: regression and removed severity3: broken labels Dec 18, 2018

alan-agius4 mentioned this issue Dec 19, 2018

Add support for Typescript 3.2 #13226

Merged

mgechev closed this as completed in #13226 Dec 19, 2018

alan-agius4 mentioned this issue Dec 20, 2018

Add tests for elide imports and fix named imports with default imports #13243

Merged

alan-agius4 mentioned this issue Jan 14, 2019

Imports with alias broken since Angular 7.2 & TypeScript 3.2 angular/angular#28123

Closed

alan-agius4 mentioned this issue Feb 2, 2019

Cannot "import as" with prod build #13577

Closed

1 task

remkoboschker mentioned this issue Feb 8, 2019

__BaseService undefined cyclosproject/ng-swagger-gen#161

Closed

jagomf mentioned this issue Jun 13, 2019

SelectOnTab not working after upgrading to Angular 7.2.15 ng-select/ng-select#1212

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`import as` results in the alias being undefined with Typescript 3.2 #13212

`import as` results in the alias being undefined with Typescript 3.2 #13212

IgorMinar commented Dec 18, 2018 •

edited

Loading

IgorMinar commented Dec 18, 2018

thw0rted commented Dec 18, 2018

thw0rted commented Dec 18, 2018

alan-agius4 commented Dec 18, 2018

thw0rted commented Dec 20, 2018

IgorMinar commented Jan 27, 2019 via email

angular-automatic-lock-bot bot commented Sep 9, 2019

import as results in the alias being undefined with Typescript 3.2 #13212

import as results in the alias being undefined with Typescript 3.2 #13212

Comments

IgorMinar commented Dec 18, 2018 • edited Loading

Bug Report or Feature Request (mark with an x)

Command (mark with an x)

Versions

Repro steps

Workarounds

More info

IgorMinar commented Dec 18, 2018

thw0rted commented Dec 18, 2018

thw0rted commented Dec 18, 2018

alan-agius4 commented Dec 18, 2018

thw0rted commented Dec 20, 2018

IgorMinar commented Jan 27, 2019 via email

angular-automatic-lock-bot bot commented Sep 9, 2019

`import as` results in the alias being undefined with Typescript 3.2 #13212

`import as` results in the alias being undefined with Typescript 3.2 #13212

IgorMinar commented Dec 18, 2018 •

edited

Loading

Bug Report or Feature Request (mark with an `x`)

Command (mark with an `x`)