Pipe generated transform method has wrong parameters

[tchatel]

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [x] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

All versions are affected, including v7.0.0-rc.3.

Repro steps

ng generate pipe ...

Problem

The generated method transform has wrong parameters. The second parameter, args, will not receive all the pipe arguments, but only the first one, and other arguments are lost.

The generated method is:

transform(value: any, args?: any): any {
  return null;
}

A right version should be:

transform(value: any, ...args: any[]): any {
  return null;
}

[alan-agius4]

Not sure about this, because I think in general it preferred to specify all the parameter needed.

Example;

 transform(value: any, argOne: number, argTwo?: number): any {

[tchatel]

Yes, I agree, you should always rewrite the method with meaningful parameters and right types, even the first one (value).
It's what I explain when I give Angular trainings. But I don't like having to tell that the generated code is wrong. Generated code should not be wrong, it should not mean that all the pipe arguments will be sent in the second method parameter, since it's not what happen.

Perhaps it may generate something like that:

transform(value: any, arg1: any, arg2: any): any {

or any other syntax that won't confuse the users.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}