Skip to content

Update Wiki for 6.x #10438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
34 tasks done
filipesilva opened this issue Apr 23, 2018 · 10 comments
Closed
34 tasks done

Update Wiki for 6.x #10438

filipesilva opened this issue Apr 23, 2018 · 10 comments
Assignees
Labels
area: docs Related to the documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone

Comments

@filipesilva
Copy link
Contributor

filipesilva commented Apr 23, 2018

We need to update the Wiki to include command options and journey updates.

To track the wiki stories:

We also need to update the docs for individual commands.

We also need to add a link to the old docs

After a release, we should add schema links to the workspace file docs

@filipesilva filipesilva added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Apr 23, 2018
@filipesilva filipesilva added this to the v6.0.0 milestone Apr 23, 2018
@clydin clydin added the area: docs Related to the documentation label Apr 24, 2018
@filipesilva
Copy link
Contributor Author

We'll also need to add the library doc there.

@elvisbegovic
Copy link
Contributor

Currently even after watching presentation angular.json is out of scope to me, i have to generate same app in two app (due to i18n) and I want different architect.build.options (remove some assets from one)

I can run ng build --configuration=myConf it will point architect.build.configurations but what about architect.build.options how have multiple options?
like ng build --options=myOptions

Thanks @filipesilva

@hansl hansl self-assigned this Apr 27, 2018
@filipesilva filipesilva assigned Brocco and filipesilva and unassigned hansl Apr 28, 2018
@filipesilva
Copy link
Contributor Author

Heya @istiti, you can override any options you want in configurations. For instance, you can have:

"architect": {
  "build": {
    "builder": "@angular-devkit/build-angular:browser",
    "options": {
      "assets": [
        {
          "glob": "**/*",
          "input": "src/assets",
          "output": "/assets"
        }
      ],
    },
    "configurations": {
      "language-fr": {
        "i18nLocale": "fr",
        "i18nFile": "src/locale/messages.fr.xlf",
        "assets": [],
      },
      "language-de": {
        "i18nLocale": "de",
        "i18nFile": "src/locale/messages.de.xlf",
        "assets": [],
      }
    }
  },

This should give you i18n for two different languages, without assets. Is this what you wanted?

@elvisbegovic
Copy link
Contributor

@filipesilva thanks but have you tried this ?
because on my side if I reset asse to empty array I get:
cli6rc7

I copy exactly your config and run ng b -c=fr it seems because assets reset to empty array it stop command without error, if I remove assets:[] it works it compile, might be a bug ?

@MickL
Copy link

MickL commented Apr 30, 2018

@filipesilva If i put options like sourceMap into architect.build.options it is also applied to architect.serve.options?

I want to set defaults for build like "sourceMap": false which should not be applied to serve. But right now i have to repeat myself:

"configurations": {
            "testing": {
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.testing.ts"
                }
              ],
              "sourceMap": false,             
            },
            "staging": {
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.staging.ts",
                }
              ],
              "sourceMap": false,
            },
            "production": {
              "fileReplacements": [
                {
                  "replace": "src/environments/environment.ts",
                  "with": "src/environments/environment.prod.ts"
                }
              ],
              "sourceMap": false,
            }
}

@filipesilva
Copy link
Contributor Author

filipesilva commented Apr 30, 2018

@istiti that is indeed a bug, I know what's wrong and will fix (angular/devkit#819)

@MickL Yes, what you put in build will be applied to serve since the dev server will use the build options. However, sourceMap is one of the (few) build options that you can override in serve (angular/devkit#734).

@hansl
Copy link
Contributor

hansl commented May 1, 2018

Reopening as this was not meant to be closed (yet).

@ghost
Copy link

ghost commented May 2, 2018

configure-hmr (pr - #10500)

If you follow the docs, you will end up with

Schema validation failed with the following errors:
  Data path "['serve'].configurations['hmr']" should be object.
Error: Schema validation failed with the following errors:
  Data path "['serve'].configurations['hmr']" should be object.

Fixed with PR #10592

filipesilva added a commit to filipesilva/angular-cli that referenced this issue May 2, 2018
@filipesilva
Copy link
Contributor Author

@robertbaker sorry for that, I have pushed a fix in #10603. The file replacement was also missing.

I'm closing this issue because all the items I had in the original list are addressed.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: docs Related to the documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

6 participants