Skip to content

ng update --next should deduplicate angular packages and just show core #10248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StephenFluin opened this issue Apr 9, 2018 · 2 comments
Closed
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone

Comments

@StephenFluin
Copy link
Contributor

Versions

Angular CLI: 6.0.0-rc.2
Node: 9.2.0
OS: linux x64
Angular: 6.0.0-rc.3
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 6.0.0-rc.2
@angular-devkit/architect: 0.5.4
@ngtools/json-schema: 1.2.0
@schematics/update: 0.5.4
typescript: 2.7.2
webpack: error

Repro steps

ng update --next

Observed behavior

ng update --next
    We analyzed your package.json, there are some packages to update:
    
      Name                               Version                    Command to update
     ---------------------------------------------------------------------------------------------------------
      @angular/animations                5.2.9 -> 6.0.0-rc.3        ng update @angular/animations
      @angular/common                    5.2.9 -> 6.0.0-rc.3        ng update @angular/common
      @angular/compiler                  5.2.9 -> 6.0.0-rc.3        ng update @angular/compiler
      @angular/compiler-cli              5.2.9 -> 6.0.0-rc.3        ng update @angular/compiler-cli
      @angular/core                      5.2.9 -> 6.0.0-rc.3        ng update @angular/core
      @angular/forms                     5.2.9 -> 6.0.0-rc.3        ng update @angular/forms
      @angular/http                      5.2.9 -> 6.0.0-rc.3        ng update @angular/http
      @angular/language-service          5.2.9 -> 6.0.0-rc.3        ng update @angular/language-service
      @angular/platform-browser          5.2.9 -> 6.0.0-rc.3        ng update @angular/platform-browser
      @angular/platform-browser-dynamic  5.2.9 -> 6.0.0-rc.3        ng update @angular/platform-browser-dynamic
      @angular/router                    5.2.9 -> 6.0.0-rc.3        ng update @angular/router
      typescript                         2.5.3 -> 2.9.0-dev.20180409  npm install typescript
    
    
    There might be additional packages that are outdated.
    Or run ng update --all to try to update all at the same time.
    
Nothing to be done.

Desired behavior

ng update should tell me what to do next, and take into account its own context.

if ng update @angular/core updates all of these synced packages, then all should be grouped. We should be treating them all like one thing unless there's an exception and one is out of date. We want to help people think about them as a single unit.

@hansl
Copy link
Contributor

hansl commented Apr 10, 2018

We need to show only the first package name of the group.

@hansl hansl added this to the v6.0.0 milestone Apr 12, 2018
@hansl hansl added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed 6.0.0-rc severity3: broken labels Apr 12, 2018
@hansl hansl self-assigned this Apr 13, 2018
hansl added a commit to hansl/devkit that referenced this issue Apr 14, 2018
Packages will be reduced to their package name. Added the spec for the new
packageGroupName argument (default to the first item of the packageGroup).

Fixes angular/angular-cli#10248
Fixes angular/angular-cli#10247
filipesilva pushed a commit to angular/devkit that referenced this issue Apr 14, 2018
Packages will be reduced to their package name. Added the spec for the new
packageGroupName argument (default to the first item of the packageGroup).

Fixes angular/angular-cli#10248
Fixes angular/angular-cli#10247
hansl added a commit that referenced this issue Jun 6, 2018
Packages will be reduced to their package name. Added the spec for the new
packageGroupName argument (default to the first item of the packageGroup).

Fixes #10248
Fixes #10247
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

3 participants