Skip to content

schema link missing in angular.json that was created by updating from 1.7.3 to 6-rc.2 #10226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IgorMinar opened this issue Apr 7, 2018 · 1 comment
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion severity2: inconvenient
Milestone

Comments

@IgorMinar
Copy link
Contributor

IgorMinar commented Apr 7, 2018

Versions

cli rc.2

Repro steps

  • get a project built by 1.7.3
  • update cli in package.json to 6.0.0-rc.2 + yarn install
  • ng update @angular/cli --migrate-only --from=1.7.3

Observed behavior

angular.json is generated without the schema link:

{
  "version": 1,
  ...
}

Desired behavior

angular.json should look like this:

{
  "$schema": "./node_modules/@angular-devkit/core/src/workspace/workspace-schema.json",
  "version": 1,
  ...
}

Mention any other details that might be useful (optional)

@clydin pointed out that the upgrade code is missing the schema key: https://github.com/angular/devkit/blob/8e6c762c94de1c23bc8b53f1cb87b48726eda951/packages/schematics/angular/migrations/update-6/index.ts#L72

@hansl hansl added this to the v6.0.0 milestone Apr 12, 2018
@hansl hansl added P5 The team acknowledges the request but does not plan to address it, it remains open for discussion and removed 6.0.0-rc labels Apr 12, 2018
@clydin clydin self-assigned this Apr 12, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
@clydin clydin removed their assignment Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion severity2: inconvenient
Projects
None yet
Development

No branches or pull requests

4 participants