Skip to content

Commit 71428bd

Browse files
committed
Revert "feat(@angular/cli): Add VsCode recommendation for Angular Console"
This reverts commit 3d6ae63.
1 parent 242ebd9 commit 71428bd

File tree

3 files changed

+9
-20
lines changed

3 files changed

+9
-20
lines changed

packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,12 @@ export default function (): Rule {
1515
const addExtensionRecommendations = updateJsonInTree(
1616
'.vscode/extensions.json',
1717
(json: { recommendations?: string[] }) => {
18-
[
19-
'angular.ng-template',
20-
'nrwl.angular-console',
21-
'ms-vscode.vscode-typescript-tslint-plugin'].forEach(extension => {
22-
json.recommendations = json.recommendations || [];
23-
if (!json.recommendations.includes(extension)) {
24-
json.recommendations.push(extension);
25-
}
26-
});
18+
['angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'].forEach(extension => {
19+
json.recommendations = json.recommendations || [];
20+
if (!json.recommendations.includes(extension)) {
21+
json.recommendations.push(extension);
22+
}
23+
});
2724

2825
return json;
2926
},

packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ describe('Update 8.0.0', () => {
3535
.toPromise();
3636

3737
expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({
38-
recommendations: [
39-
'angular.ng-template', 'nrwl.angular-console', 'ms-vscode.vscode-typescript-tslint-plugin'],
38+
recommendations: ['angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'],
4039
});
4140
});
4241

@@ -45,10 +44,7 @@ describe('Update 8.0.0', () => {
4544
.callRule(
4645
updateJsonInTree('.vscode/extensions.json', () => ({
4746
recommendations: [
48-
'eamodio.gitlens',
49-
'angular.ng-template',
50-
'nrwl.angular-console',
51-
'ms-vscode.vscode-typescript-tslint-plugin'],
47+
'eamodio.gitlens', 'angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'],
5248
})),
5349
initialTree,
5450
)
@@ -60,10 +56,7 @@ describe('Update 8.0.0', () => {
6056

6157
expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({
6258
recommendations: [
63-
'eamodio.gitlens',
64-
'angular.ng-template',
65-
'nrwl.angular-console',
66-
'ms-vscode.vscode-typescript-tslint-plugin'],
59+
'eamodio.gitlens', 'angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'],
6760
});
6861
});
6962
});
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
"recommendations": [
33
"angular.ng-template",
4-
"nrwl.angular-console",
54
"ms-vscode.vscode-typescript-tslint-plugin"
65
]
76
}

0 commit comments

Comments
 (0)