Skip to content

Commit 242ebd9

Browse files
committed
Revert "feat(@schematics/angular): recommend plugins that John Papa recommends"
This reverts commit 3a68b8c.
1 parent ef11c9f commit 242ebd9

File tree

3 files changed

+12
-29
lines changed

3 files changed

+12
-29
lines changed

packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,7 @@ const addExtensionRecommendations = updateJsonInTree(
1818
[
1919
'angular.ng-template',
2020
'nrwl.angular-console',
21-
'ms-vscode.vscode-typescript-tslint-plugin',
22-
'Mikael.Angular-BeastCode',
23-
'EditorConfig.EditorConfig',
24-
'msjsdiag.debugger-for-chrome',
25-
'eg2.vscode-npm-script',
26-
'PKief.material-icon-theme',
27-
'natewallace.angular2-inline'].forEach(extension => {
21+
'ms-vscode.vscode-typescript-tslint-plugin'].forEach(extension => {
2822
json.recommendations = json.recommendations || [];
2923
if (!json.recommendations.includes(extension)) {
3024
json.recommendations.push(extension);

packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,6 @@ import { Tree } from '@angular-devkit/schematics';
99
import { SchematicTestRunner } from '@angular-devkit/schematics/testing';
1010
import { readJsonInTree, serializeJson, updateJsonInTree } from './ast-utils';
1111

12-
const recommendations = [
13-
'angular.ng-template',
14-
'nrwl.angular-console',
15-
'ms-vscode.vscode-typescript-tslint-plugin',
16-
'Mikael.Angular-BeastCode',
17-
'EditorConfig.EditorConfig',
18-
'msjsdiag.debugger-for-chrome',
19-
'eg2.vscode-npm-script',
20-
'PKief.material-icon-theme',
21-
'natewallace.angular2-inline',
22-
];
23-
2412
describe('Update 8.0.0', () => {
2513
let initialTree: Tree;
2614
let schematicRunner: SchematicTestRunner;
@@ -46,7 +34,10 @@ describe('Update 8.0.0', () => {
4634
.runSchematicAsync('migration-07', {}, initialTree)
4735
.toPromise();
4836

49-
expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({recommendations});
37+
expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({
38+
recommendations: [
39+
'angular.ng-template', 'nrwl.angular-console', 'ms-vscode.vscode-typescript-tslint-plugin'],
40+
});
5041
});
5142

5243
it('should add to existing vscode extension recommendations', async () => {
@@ -55,7 +46,9 @@ describe('Update 8.0.0', () => {
5546
updateJsonInTree('.vscode/extensions.json', () => ({
5647
recommendations: [
5748
'eamodio.gitlens',
58-
...recommendations],
49+
'angular.ng-template',
50+
'nrwl.angular-console',
51+
'ms-vscode.vscode-typescript-tslint-plugin'],
5952
})),
6053
initialTree,
6154
)
@@ -68,7 +61,9 @@ describe('Update 8.0.0', () => {
6861
expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({
6962
recommendations: [
7063
'eamodio.gitlens',
71-
...recommendations],
64+
'angular.ng-template',
65+
'nrwl.angular-console',
66+
'ms-vscode.vscode-typescript-tslint-plugin'],
7267
});
7368
});
7469
});

packages/schematics/angular/workspace/files/__dot__vscode/extensions.json.template

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,6 @@
22
"recommendations": [
33
"angular.ng-template",
44
"nrwl.angular-console",
5-
"ms-vscode.vscode-typescript-tslint-plugin",
6-
"Mikael.Angular-BeastCode",
7-
"EditorConfig.EditorConfig",
8-
"msjsdiag.debugger-for-chrome",
9-
"eg2.vscode-npm-script",
10-
"PKief.material-icon-theme",
11-
"natewallace.angular2-inline"
5+
"ms-vscode.vscode-typescript-tslint-plugin"
126
]
137
}

0 commit comments

Comments
 (0)