This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Comments for query.dart #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbdeboer
commented
Sep 4, 2014
jbdeboer
commented
| @@ -34,5 +35,6 @@ library angular.directive_injector.query; | |||
| * | |||
| * DESIGN: https://docs.google.com/document/d/1d-yxmxMVqZHHadvxQaC2CCvcAR17JUQ1Qs4RT6Rwp6Y | |||
| */ | |||
| // COMMENT(deboer): This should by a List isn't of an UnmodifieableListView since the set of elements can change over the course of the Query's life time. | |||
There was a problem hiding this comment.
I think unmodifiable is the right API for clients. While internally (in the DirectiveInjector) it is modifiable, we don't want the clients to muck with it.
I would argue that providing DOM-consistent indexing might be too hard on first iteration (given ng-if, ng-repeat might wildly rearrange the Dom elements), and would just give one method forEach.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.