Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Angular 1.2.x model binding support #59

Closed
wants to merge 1 commit into from

Conversation

shaunrader
Copy link
Contributor

I don't see a pull request to fix the model binding issues with Angular 1.2.x described in #49. Thanks to @iwang for the research, solution, and write up on the issue!

@leostera
Copy link

👍

@pablocaselas
Copy link

Why is this not merged?

Thanks @shaunrader!!

@xaralis
Copy link

xaralis commented Jan 20, 2014

Please please merge this!

@osimicek
Copy link

+1

@zhongliangong
Copy link

I did wonder whether to make a similar commit, but I'm unsure whether hardcoding the priority would cause problems with other modules. Is there a way to check for that?

@cgwyllie
Copy link

+1

@akarl
Copy link

akarl commented Feb 3, 2014

You can do this to change the priority without modifying external dependencies:

$provide.decorator('uiTinymceDirective', ['$delegate', function($delegate) {
    $delegate[0].priority = 1;
    return $delegate;
}]);

@andrew-cunliffe
Copy link

👍 just spent 2 hours trying to figure out how to hack this to work, manually added the value but whenever I run bower now the fix is throw out, thanks to @akarl818 for the comment on how to fix this without the change to tinymce, but would prefer the real fix is implemented :)

@techniq
Copy link

techniq commented Mar 27, 2014

Thanks @akarl818, that workaround until this PR gets merged worked great.

@wesleycho
Copy link
Contributor

Landed as 613ae99

Thanks!

@wesleycho wesleycho closed this Apr 19, 2014
@wesleycho
Copy link
Contributor

Interestingly enough, this addressed a testing issue I was having in trying to get commented out spec to work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.