This repository was archived by the owner on Sep 8, 2020. It is now read-only.
fix($dirty): check if editor is dirty before updating view #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for putting this up. Will take a look over it tonight. Something that helps us is putting up a plunker with the fix so it is easy for us to test. Also if you could add a test which verifies your fix that would be great. |
|
Plunker with issue: http://plnkr.co/edit/INfZpLpz2yrRvlHitw1N I will try to set up a few tests, but it will take some time. |
| @@ -63,8 +63,10 @@ angular.module('ui.tinymce', []) | |||
| $timeout.cancel(debouncedUpdateTimer); | |||
| debouncedUpdateTimer = $timeout(function() { | |||
| return (function(ed) { | |||
| ed.save(); | |||
| updateView(ed); | |||
| if (!ed.isNotDirty) { | |||
There was a problem hiding this comment.
I think we want ed.isDirty() instead.
|
this fix solves the problem for me, thx for sharing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #238
thats my first PR, I hope I haven't messed it up 💥