This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Angular1.2 #56
Merged
Angular1.2 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 9, 2013 09:20
thgreasi
added a commit
to thgreasi/ui-sortable
that referenced
this pull request
Nov 19, 2013
* Formating changes * Renamed injected log to $log * Replaced apply function with inlined anonymus
thgreasi
added a commit
that referenced
this pull request
Nov 19, 2013
Summary of code changes (in code order): * Removed apply() in favor of inlined anonymous functions * Removed ngModel.$render * Added scope.$watch for attrs.ngModel * Added callbacks.activate to store elements of ngRepeat and positions * Added callbacks.receive to record a receive * Minor changes to callbacks.stop that now utilizes values saved earlier * Major changes to callbacks.update * Minor changes to scope.$watch(attrs.uiSortable), (can be backported)
|
Couldn't auto merge as you see despite all the effort to minimize the diff's.
Now we just need to wait for extra reviewers and we can merge it to master. |
|
Glad I could help. I'm happy we were able to get it pushed through. Now I can change my bower dependencies back to the official repo. Who are the extra reviewers for this? I would love to get this into master (I'm pretty sure it's backwards compatible), and cut a new release on bower so I don't have to have a branch specified in my bowerfile. |
thgreasi
added a commit
that referenced
this pull request
Dec 28, 2013
Summary of code changes (in code order): * Removed apply() in favor of inlined anonymous functions * Removed ngModel.$render * Added scope.$watch for attrs.ngModel * Added callbacks.activate to store elements of ngRepeat and positions * Added callbacks.receive to record a receive * Minor changes to callbacks.stop that now utilizes values saved earlier * Major changes to callbacks.update * Minor changes to scope.$watch(attrs.uiSortable), (can be backported)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting ui-sortable to work with the new way angular does ng-repeat.