Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

docs(README): fix broken jquery-ui floating issue link #454

Merged
merged 1 commit into from
May 7, 2016

Conversation

mooyoul
Copy link
Contributor

@mooyoul mooyoul commented May 6, 2016

Cheers 🍻

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9e935bf on mooyoul:master into 4f18c64 on angular-ui:master.

@thgreasi thgreasi closed this May 7, 2016
@thgreasi thgreasi reopened this May 7, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9e935bf on mooyoul:master into 4f18c64 on angular-ui:master.

@thgreasi
Copy link
Contributor

thgreasi commented May 7, 2016

It sounds strange that it didn't work but anyway having a protocol in front of a url is never bad, especially if it's https. Nice catch 👍

@thgreasi thgreasi merged commit 85c0453 into angular-ui:master May 7, 2016
@thgreasi
Copy link
Contributor

thgreasi commented May 7, 2016

Ok got the error as well... Something probably changes in the markdown url parsing. Thanks again 👍

@mooyoul
Copy link
Contributor Author

mooyoul commented May 8, 2016

Yup i think Markdown link is just equal as href of a tag. So browser guess that link which is without protocol as relative link. Not an absolute link. Thanks for your reply!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants