Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

fix(sortable): manage appendTo option #263

Merged
merged 1 commit into from
Sep 7, 2014
Merged

fix(sortable): manage appendTo option #263

merged 1 commit into from
Sep 7, 2014

Conversation

d33d33
Copy link
Contributor

@d33d33 d33d33 commented Sep 6, 2014

appendTo option mess up ng-repeat comments

See : demo

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cdc034b on Intia:appendTo into 5168154 on angular-ui:master.

@thgreasi
Copy link
Contributor

thgreasi commented Sep 6, 2014

👍
I will merge this as soon as I get some time to write a test case.
Unfortunately the v0.13.0-dev branch takes all my time lately.
On the other hand, I think that your example will be a good starting point for the test case.

appendTo option mess up ng-repeat comments
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d5365e7 on Intia:appendTo into 5168154 on angular-ui:master.

@d33d33
Copy link
Contributor Author

d33d33 commented Sep 7, 2014

I just add one E2E test 😃

@thgreasi
Copy link
Contributor

thgreasi commented Sep 7, 2014

GJ 👍
Will review and merge tonight!

thgreasi added a commit that referenced this pull request Sep 7, 2014
fix(sortable): manage appendTo option
@thgreasi thgreasi merged commit 34ed7bf into angular-ui:master Sep 7, 2014
@thgreasi
Copy link
Contributor

thgreasi commented Sep 7, 2014

Thanks!

@d33d33
Copy link
Contributor Author

d33d33 commented Sep 9, 2014

You're welcome

@d33d33 d33d33 deleted the appendTo branch September 9, 2014 00:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants