Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Fix wrong dirty flag when initializing select2 via expressions #173

Closed
wants to merge 1 commit into from
Closed

Fix wrong dirty flag when initializing select2 via expressions #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/select2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,18 @@ angular.module('ui.select2', []).value('uiSelect2Config', {}).directive('uiSelec
// Not sure if I should just check for !isSelect OR if I should check for 'tags' key
if (!opts.initSelection && !isSelect) {
var isPristine = controller.$pristine;
if(isPristine)
{
//fix wrong dirty flag when initializiing via expression
controller.$pristine = false;
controller.$dirty = true;
}
controller.$setViewValue(
convertToAngularModel(elm.select2('data'))
);
if (isPristine) {
controller.$pristine = true;
controller.$dirty = false;
controller.$setPristine();
}
elm.prev().toggleClass('ng-pristine', controller.$pristine);
Expand Down
2 changes: 2 additions & 0 deletions test/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ module.exports = function(config) {
files: [
// Dependencies
'bower_components/jquery/jquery.js',
'bower_components/jquery/dist/jquery.js',
'bower_components/angular/angular.js',
'bower_components/angular-mocks/angular-mocks.js',
'bower_components/select2/select2.js',


// Source Code
'src/select2.js',
Expand Down