This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Update select2.js #106
Closed
Update select2.js #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In AngularJS 1.2.1 the newly defined controller.$render method never got called. I believe because the method already exists and the call is declared above the new declaration. Could be wrong on that though - just a guess. I just changed the method name to be unique and it is called now.
|
According to that blog post, the priority is the issue, not the render function. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AngularJS 1.2.1 the newly defined controller.$render method never got called. I believe because the method already exists and the call is done above the new declaration. Could be wrong on that though - just a guess. I just changed the method name to be unique and it is called now.