This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fixing issue while locking elements with bind to single property and async loading #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…async loading _uiSelectChoiceLocked cannot be assigned to primitive type
| @@ -323,7 +323,10 @@ uis.controller('uiSelectCtrl', | |||
|
|
|||
| if (item && !angular.isUndefined(ctrl.lockChoiceExpression)) { | |||
| isLocked = !!(itemScope.$eval(ctrl.lockChoiceExpression)); // force the boolean value | |||
| item._uiSelectChoiceLocked = isLocked; // store this for later reference | |||
| //we need to check if it's an object while doing bind to single property and async loading | |||
| if(typeof(item) === 'object') { | |||
There was a problem hiding this comment.
Use angular.isObject(item)
user378230
added a commit
to user378230/ui-select
that referenced
this pull request
Jul 9, 2016
Previously setting a selected item as locked modified that item, this could cause issues if the item was used outside of the directive. This commit changes the directive to store the information internally thus preventing it from interfering with external uses. Closes angular-ui#1269 and angular-ui#514 Supersedes (and closes) angular-ui#1641 and angular-ui#952
user378230
added a commit
to user378230/ui-select
that referenced
this pull request
Jul 9, 2016
Previously setting a selected item as locked modified that item, this could cause issues if the item was used outside of the directive. This commit changes the directive to store the information internally thus preventing it from interfering with external uses. Closes angular-ui#1269 and angular-ui#514 Supersedes (and closes) angular-ui#1641 and angular-ui#952
user378230
added a commit
to user378230/ui-select
that referenced
this pull request
Jul 9, 2016
Previously setting a selected item as locked modified that item, this could cause issues if the item was used outside of the directive. This commit changes the directive to store the information internally thus preventing it from interfering with external uses. Closes angular-ui#1269 and angular-ui#514 Supersedes (and closes) angular-ui#1641 and angular-ui#952
|
Superseded by #1712 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_uiSelectChoiceLocked cannot be assigned to primitive type