Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Use npm to install required dependencies to run the tests. #945

Merged
merged 1 commit into from
Mar 23, 2016
Merged

Use npm to install required dependencies to run the tests. #945

merged 1 commit into from
Mar 23, 2016

Conversation

yagoferrer
Copy link
Contributor

Angular, Angular Sanitize, Angular Mocks and JQuery.
Removed: post-install bower script. No longer need to call bower from npm.
This will help when you guys decide to publish the package in NPM.

…gular Sanitize, Angular Mocks and JQuery.

Removed: post-install bower script. No longer need to call bower from npm.
@JasonMore
Copy link

+1 from me. I was just about to post a PR with not using bower at all, since I'm using UI-Select with webpack as a faux npm module.

  "dependencies": {
    // cruft removed
    "ui-select": "git://github.com/angular-ui/ui-select"
}

@Anahkiasen
Copy link

Any news on this one?

@user378230
Copy link
Contributor

This doesn't seem like a bad idea...

@aaronroberson thoughts?

@aaronroberson
Copy link
Contributor

@yagoferrer and @JasonMore You can install ui-select from npm currently. The official npm package can be found here: https://www.npmjs.com/package/ui-select

With that said, I'm going to merge this PR in because it is a good idea :D

@aaronroberson aaronroberson merged commit 1a80bf1 into angular-ui:master Mar 23, 2016
user378230 pushed a commit to user378230/ui-select that referenced this pull request Mar 30, 2016
Following merge of angular-ui#945 bower is not longer required for development,
this commit removes it from travis build and dev setup docs.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants