Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

feat(focusable): allow control to be get focus. Support for tab navigati... #92

Merged
merged 2 commits into from
Jul 3, 2014

Conversation

dimirc
Copy link
Contributor

@dimirc dimirc commented Jun 30, 2014

Changes:

  • Accesible for tab-key navigation
  • Can start typing even when the dropdown isn't open, just with focus
  • Can open dropdown with enter, up-down-left-right keys when focus
  • Isn't focusable when the control is disabled

Working plunker

Resolves #51

@dimirc
Copy link
Contributor Author

dimirc commented Jun 30, 2014

Travis is falling but doesn't seem related to this PR since same failing tests appear from current master branch. Maybe we should merge first #91 since tests are passing this those changes

@dimirc dimirc added this to the 0.3.x milestone Jun 30, 2014
@mattiash
Copy link

mattiash commented Jul 2, 2014

I have tested the plunker and it is possible to use the keyboard to update the field. However, when I want to use a normal select I use Tab to focus the select and then I press Space to open the dropdown. In the plunker, Space does not open the dropdown.

Shouldn't Space open the dropdown since it does so in a normal select? One way of handling it would be to strip leading and terminating whitespace in the search criteria, meaning that if the search field contains only whitespace, it matches everything and thus all entries are displayed.

@dimirc
Copy link
Contributor Author

dimirc commented Jul 3, 2014

@mattiash we'll be able to do that now, I just pushed a new commit with this change. You can check plunker again

@mattiash
Copy link

mattiash commented Jul 3, 2014

@dimirc Great! I have tested the updated plunker and Space opens the dropdown now. Thank you!

dimirc added a commit that referenced this pull request Jul 3, 2014
feat(focusable): allow control to be get focus. Support for tab navigati...
@dimirc dimirc merged commit 6b76dda into master Jul 3, 2014
@dimirc dimirc deleted the feat-focusable branch July 3, 2014 21:18
@SimeonC SimeonC mentioned this pull request Jul 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus doesn't work with Select2 theme
2 participants