Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Multiple #78

Closed
wants to merge 2 commits into from
Closed

Multiple #78

wants to merge 2 commits into from

Conversation

komakino
Copy link

@komakino komakino commented Jun 4, 2014

Added initial support for multiple choices. …
Still to do:

  • Selectize template
  • Write tests
  • Only tested in Chrome, so other browser tests needs to be done
  • Possibly find a way to remove items from drop down that are currently selected
  • A user provided compare function to determine if an initially selected item matches an item in ctrl.items. Currently uses angular.equals
  • more

Other minor changes

  • Remove Tab key events; they were illogical and prevented ui-select from functioning correctly in a form

komakino added 2 commits May 31, 2014 20:50
Still to do:
 - Selectize and Bootstrap templates
 - Write tests
 - Only tested in Chrome, so other browser tests needs to be done
 - Possibly find a way to remove items from drop down that are currently selected
 - A user provided compare function to determine if an initially selected item matches an item in ctrl.items. Currently uses angular.equals
 - more

Other minor changes
 - Remove Tab key events; they were illogical and prevented ui-select from functioning correctly in a form
@komakino
Copy link
Author

komakino commented Jun 4, 2014

No done yet, but created PR to get more input and possibly some help.

@mping
Copy link

mping commented Jun 16, 2014

Any news on this? I would love to use a pure angular alternative to select2.

@jgoux
Copy link

jgoux commented Jun 25, 2014

+1
I'm looking forward this PR before using ui-select in my projects.

@dimirc
Copy link
Contributor

dimirc commented Jul 15, 2014

@komakino can you rebase with current master? I'd like to help to merge this asap

@dimirc dimirc added this to the 0.6.0 milestone Jul 15, 2014
@dimirc dimirc mentioned this pull request Jul 15, 2014
@mping
Copy link

mping commented Jul 21, 2014

@komakino any progress on this? I can lend a hand if you like

@diegodurs
Copy link

+1 I would love to see that!

@brafkind
Copy link

+1

@PowerKiKi
Copy link

@komakino could you rebase your PR so that it does not merge conflict anymore, please ? I think it would increase the chance of being merged.

@alex6o
Copy link

alex6o commented Jul 31, 2014

+1

1 similar comment
@chumster
Copy link

+1

@dimirc dimirc mentioned this pull request Aug 4, 2014
16 tasks
@dimirc
Copy link
Contributor

dimirc commented Aug 4, 2014

Rebase done at #138, lets keep discussion there.

@dimirc dimirc closed this Aug 4, 2014
@dimirc dimirc removed this from the 0.6.x milestone Aug 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants