This repository was archived by the owner on Oct 2, 2019. It is now read-only.
isEmpty also true when selected == 0 #687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -195,7 +195,7 @@ | |||
| ctrl.$filter = $filter; | |||
|
|
|||
| ctrl.isEmpty = function() { | |||
| return angular.isUndefined(ctrl.selected) || ctrl.selected === null || ctrl.selected === ''; | |||
| return angular.isUndefined(ctrl.selected) || ctrl.selected === null || ctrl.selected === '' || ctrl.selected === 0; | |||
There was a problem hiding this comment.
Not sure if this will be ok since 0 could be a value, so it isn't actually empty. This function will make the placeholder appear even when the user selects 0as value
There was a problem hiding this comment.
I understand. Thanks. Probably not an issue anymore when #302 is implemented.
|
I agree with dimirc comments. So closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems kind of logically
greetings