refresh on active

[abudel]

From #271,
By setting to true the attribute "refresh-on-active" in the "ui-select-choiche", refresh method is called when the component is activated the first time.

[dimirc]

Can you add some tests?

[diogodomanski]

I've followed the instructions posted by abudel, but it didn't work.

[abudel]

Hi diogodomanski
you need to build the repository. Btw i made a plunker to see it in action.
Hope with this example you can figure it out.

[diogodomanski]

Thanks abudel. When will this feature be available in master branch?

[dimirc]

@abudel LGTM. As you might saw already, the source was split onto multiple files, can you rebase this PR so I can merge it?

PD:Will be better if you just create a new branch from current master and apply all the changes, then just do a git push origin --force to overwrite the old commits

[abudel]

@dimirc thanks! i updated the repo as you asked.

[Envek]

@abudel it's hard to test your changes as dist/select.js doesn't contain changes from src/*.js files (so it doesn't work), I had to patch dist/select.js manually in my app. After that everything worked 🎆!
Please clean up your pull request: dist/select.js should contain only your changes and not 1000+ unrelated ones (it's not even possible to see diff on GitHub). Changes to bower.json and other files probably also shouldn't go into PR. You probably should do as @dimirc have said above (new branch, apply changes, forced push of new branch to this branch).

But thank you very much for your work! 👍 This PR will definitely fix my #619 issue after merging and publishing in bower.

[dimirc]

@abudel I still see changes to /dist files. Pls keep in mind that we should only change /src files. Also could you try to squash it all into one commit?

Let me know if you have any trouble on this changes.

[abudel]

@dimirc i don't get it. i tried to follow your instructions: 33f4d9f. Confused 😕

[Envek]

@abudel In your fork's master branch (and it's specified as this PR branch) there is currently not only commit 33f4d9f but also another commits after it with various merges and so on. See your fork's Network page for a visual representation.

If you do not need these extra commits in your fork's master, you can do the following:

git checkout master             # Ensure we are on source branch
git reset --hard 33f4d9f        # Cut it to this commit
git push origin master --force  # Overwrite remote branch to be the same as local branch (to end with 33f4d9f)

After that contents of this PR will be updated. Please note that other commits from your master branch will disappear. If you do need these commits, please create a new branch from commit 33f4d9f and create a new PR from it (I see that there is a refresh-on-active branch).

This article from GitHub Help may help you: Using pull requests

[abudel]

@Envek thanks for your help. I followed your instructions.
@dimirc Now it should be ok.

[Envek]

@dimirc can you please take a look?
@abudel seems like it needs to be rebased.

[diogodomanski]

Can anyone fix these merge conflits and make this feature available in master branch? Thanks

[milkolori]

Hey guys will this feature be available in the master brach, it is very useful?

[venkatesh13]

+1 Really Usefull. add this one to master. Thank you

[dmitry-dedukhin]

It's a must-have feature, could you please integrate it?

[sdvcrx]

+1

[dmitry-dedukhin]

Hi.

Seems that this can be achieved by custom directive like the following:

myModule.directive('uiSelectLazyLoad', function ($parse) {
    return {
        restrict: 'A',
        scope: true, // create new but not isolated scope
        compile: function (element, attrs) {
            var $choices = element.find('ui-select-choices'),
                refreshAttr = $choices.attr('refresh'),
                refreshFunc = null;

            if(!refreshAttr) {
                return;
            }

            refreshFunc = $parse(refreshAttr, /* interceptorFn */ null, /* expensiveChecks */ true);

            // replace all 'refresh' contents by own function
            $choices.attr('refresh', 'ptUiSelectLazyLoadHandler($event)');

            return function linkFn(scope, element, attrs) {
                var activated = false;

                element.one('click', function () {
                    activated = true;
                    scope.ptUiSelectLazyLoadHandler();
                });

                scope.ptUiSelectLazyLoadHandler = function ($event) {
                    if(!activated) {
                        return;
                    }
                    refreshFunc(scope);
                };
            };
        }
    };
});

The directive can be used like this:

        <ui-select ng-model="dummy" ui-select-lazy-load>
            <ui-select-match>{{$select.selected.name}}</ui-select-match>
            <ui-select-choices
                    repeat="soft.id as soft in softs"
                    refresh="loadSoft($select.search)"
                    refresh-delay="200">
                <div ng-bind-html="soft.name | highlight: $select.search"></div>
            </ui-select-choices>
        </ui-select>

Function specified in "refresh" attribute on <ui-select-choices> will be called first time only after control "activation" i.e. after first click on ui-select.

[Gillardo]

+1, must have feature!

[ghost]

+1

[Falldog]

+1

[maxzubr]

+1

[fabio-paiva-sp]

+1

[ronaldotijucas]

+1

[krotkiewicz]

+1

[maiiku]

+1

[shogondo]

+1

[maxbundchen]

Will this feature be in the dist? It's a must-have!

[adrien-k]

+1

[dilerarc]

+1

[ftferes]

+1

[jeremypeters]

+1

[Gillardo]

when is this going to be pulled into master?

[PRISMAY]

+1

[oromand]

+1

[gustavogsimas]

Why is this not pulled yet? Its an awesome feature... +1

[user378230]

@twizzzlers:

This branch has conflicts that must be resolved

Note you could probably achieve this with custom directive such as:

app.directive('refreshOnActivate', function() {
  return {
    require: 'uiSelect',
    link: function(scope, element, attrs, $select) {
      var _activate = $select.activate;     
      $select.activate = function (initSearchValue, avoidReset) {        
        _activate(initSearchValue, avoidReset);
        $select.refresh();
      }
    }
  };
});

[shyamal890]

Any update on this feature?

[user378230]

@shyamal890 My reply is literally just before yours! 😅

[shyamal890]

@user378230 Thats right, but I was wondering when the solution would be added to master?

[user378230]

It can't be, as I said in my reply: This branch has conflicts that must be resolved

@shyamal890 also did you try using separate directive as I mentioned?

[kotmatpockuh]

+1

[fabiopaiva-praxis]

This works for me:

<ui-select-choices refresh="myCustomRefresh($select.search)" refresh-on-active="true"></ui-select-choices>

app.directive('refreshOnActive', refreshOnActive);

function refreshOnActive() {
    return {
        restrict: 'A',
        link: refreshOnActiveLink,
        scope: {
            refreshOnActive: '=',
            refresh: '@'
        }
    }

    function refreshOnActiveLink(scope, element) {
        if (! scope.refreshOnActive === true) {
            return;
        }
        var storedFunction = scope.$parent.$select.refresh;
        scope.$parent.$select.refresh = function() {};

        var element = angular.element(element).closest('.ui-select-container');
        var fn = function() {
            scope.$parent.$select.refresh = function() {
                storedFunction(scope.refresh);
            };
            scope.$parent.$select.refresh.call();
            element.unbind('click', fn);
        };
        element.bind('click', fn);
    }
}

[Jefiozie]

As the PR #1845 is merged please verify if it fix your problem.

[Jefiozie]

Closing it down due to comment above (believe this should fix it), if needed you can reopen it.
Thanks.