Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Fixes #289 #493

Closed
wants to merge 1 commit into from
Closed

Fixes #289 #493

wants to merge 1 commit into from

Conversation

CasperTDK
Copy link

Credit goes to @pandamouse

@brianfeister
Copy link

Thanks @CasperTDK but you've got a failing test there. Please fix that or think about how the test should be different before we proceed.

@pandamouse
Copy link

Ok What if we change the test to say only set the model to an array AFTER an item is selected...
https://github.com/angular-ui/ui-select/blob/master/test/select.spec.js#L1126-L1133

it('should set model as an empty array if ngModel isnt defined after an item is selected', function () {

  // scope.selection.selectedMultiple = [];
  var el = createUiSelectMultiple();
  expect(scope.selection.selectedMultiple instanceof Array).toBe(false);
  clickItem(el, 'Samantha');
  expect(scope.selection.selectedMultiple instanceof Array).toBe(true);
});

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants