This repository was archived by the owner on Oct 2, 2019. It is now read-only.
set default value to empty array #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivanvoznyakovsky Can you update this PR in the uiSelectController.js file (~ line 197)? |
|
@ivanvoznyakovsky as @aaronroberson mentioned above can you fix this PR? |
|
sorry. totally missed previous notification. |
ivanvoznyakovsky
force-pushed
the
master
branch
2 times, most recently
from
7e09b13 to
d8b3fd5
Compare
in case if items source is not defined in $scope when initializing multiselect instance of ui-select, we'll get an undefined from ctrl.parserResult.source($scope). then next line will throw an exception when truing to filter undefined.
ivanvoznyakovsky
force-pushed
the
master
branch
from
d8b3fd5 to
347c76c
Compare
|
@ivanvoznyakovsky thanks for the commit. Can you make a unit test for this? |
|
@Jefiozie added tests |
Jefiozie
approved these changes
Mar 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case if items source is not defined in $scope when initializing multiselect instance of ui-select, we'll get an undefined from ctrl.parserResult.source($scope). then next line will throw an exception when truing to filter undefined.