This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(spinner): add the refresh spinner to the select-multiple template #1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR could you add some test for this? |
The multiple mode would not show a refresh spinner even with spinner-enabled set to true. Add the same spinner html from the single selection template to the multiple selection template. Closes angular-ui#1985
yancymatherne
force-pushed
the
1985-refresh-spinner-multiple
branch
from
0391a28 to
29f41e4
Compare
|
@Jefiozie, I added tests. |
Jefiozie
approved these changes
May 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multiple mode would not show a refresh spinner even with spinner-enabled set to true. Add the same spinner html from the single selection template to the multiple selection template.
Closes #1985