This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Fix to allow select type multiple using the bootstrap theme in Firefox/IE #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to prevent clicks being swallowed when clicking on the 'x' within the multiple select pill.
Prevent the dotted line from appearing around the span element after clicking; this behavior did not occur when the span element was a button.
dimirc
added a commit
that referenced
this pull request
Oct 7, 2014
Fix to allow select type multiple using the bootstrap theme in Firefox/IE
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bootstrap theme uses a button for the ui-select-match-item element (the pill at the top after selecting one of the options). This causes the click event on the close 'x' to be swallowed in Firefox and IE.
Here's the multiple select demo with the original bootstrap theme. Open in firefox, click on the 'x' next to blue or red, observe that the pill does not go away.
http://plnkr.co/edit/he6uWGFARZsw66K2ERr5?p=preview
Here's the multiple select demo with my suggested updates.
http://plnkr.co/edit/3duaRkJZkJle9MH0Z3XV?p=preview