This repository was archived by the owner on Oct 2, 2019. It is now read-only.
disable drop under CSP #1958
Merged
disable drop under CSP #1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Apr 5, 2017
| @@ -31,6 +31,10 @@ uis.directive('uiSelectSort', ['$timeout', 'uiSelectConfig', 'uiSelectMinErr', f | |||
| } | |||
| }); | |||
|
|
|||
| if (element.data('disallowDrop')) { | |||
There was a problem hiding this comment.
rather than overriding the drop handlers in the html, simply don't set them.
There was a problem hiding this comment.
Is this needed? as I don't see anything in the code that is looking for ondrop?
There was a problem hiding this comment.
That's because the browser does it
There was a problem hiding this comment.
you are right. then we are good to go here 👍
|
@Jefiozie any idea when this might get released? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.