This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(uiSelectMultiple): ensure first item can selected #1713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue caused when using simple string item source and tagging label set to false, causing confusion in selection code between a new tag and an existing item. This refactors the selection logic to simplify the code paths and hopefully make it less prone to errors.
| $select.clear = function($event) { | ||
| $select.selected = undefined; | ||
| $event.stopPropagation(); | ||
| $timeout(function() { |
There was a problem hiding this comment.
Can you save this $timeout to a variable so that onDestroy it can be cancelled?
|
This is much more inline with the direction that the project needs to go! |
|
Parking this for the time being as I was planning on redoing the tagging stuff a bit more sanely. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue caused when using simple string item source and tagging label
set to false, causing confusion in selection code between a new tag
and an existing item.
This refactors the selection logic to simplify the code paths and
hopefully make it less prone to errors.
Possible fix for #1214